-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for testing on embedded distributions #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for compatibility with systems that implement Kodi services (e.g. Alpine) but that do not use systemd.
as `kodi_service` is more generic and accurate (for instance, Alpine Linux provides a Kodi service, but it uses OpenRC rather than systemd). BREAKING CHANGE: if calling code defines both `kodi_service` and `kodi_systemd_service`, or calling code defines `kodi_systemd_service` and the target hosts include Alpine, LibreELEC, or OSMC machines, *and* the values of `kodi_service` and `kodi_systemd_service` differ, then a fatal error will be raised. Previously, `kodi_service` would have been ignored.
as `pause` pauses playbook execution and incompatible with the `free` strategy, while `wait_for` is per-host (desirable since we are waiting for Kodi to start on a particular host, not just waiting in general) and *is* compatible with the `free` strategy.
not `kodi`.
as not all guests have `rsync` installed.
by setting `DEBIAN_FRONTEND=1` interactive and by automatically selecting a `tzdata` "Area" and "Zone". Additionally, pass `--no-install-recommends` to `apt install` to cut down on the number of packages installed (and therefore cut down on the occasion to issue any interactive prompts).
for running GitHub Actions jobs locally.
when creating the groups specified in `kodi_groups`.
as the relevant service supervision/management solution (e.g. OpenRC in Alpine) may not be running (or runnable!) inside a container.
[skipci]
tomeon
force-pushed
the
embedded-distro-tests
branch
2 times, most recently
from
February 25, 2024 17:04
74e1ab8
to
953b8b2
Compare
via a `.gitattributes` file that marks those with the `export-ignore` property (thus excluding them from `git archive` archives, which is how Ansible Galaxy creates/distributes roles).
tomeon
force-pushed
the
embedded-distro-tests
branch
from
February 25, 2024 17:06
953b8b2
to
64f7bca
Compare
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Plus a smattering of other features and fixes.
Summary:
wait_for
module (which is for waiting for a particular host) instead of thepause
module (which is for pausing Ansible's execution).root
askodi_user
on LibreELEC,kodi_groups
exist.service
module rather than using thesystemd
module, and begin migration to usingkodi_service
rather thankodi_systemd_service
. Alpine, among other distribution, does not use systemd for service supervision and management.Thank you for your consideration!