fix: ignore errors creating the groups in kodi_groups
#10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as some supported distributions (including LibreELEC) may lack `groupadd` and/or other prerequisites of the Ansible `group` module. If the group-creation tasks fail and one or more target groups do not already exist, then the task that creates `kodi_user` and adds it to `kodi_groups` will fail (so group-creation failures are safe to ignore, as any real problems will bubble up downstream).
when specifying the `groups` attribute to the Ansible `user` module.
tomeon
force-pushed
the
fix-kodi_groups-creation
branch
from
98e643f to
4dc8f86
Compare
tomeon
force-pushed
the
fix-kodi_groups-creation
branch
from
4dc8f86 to
9aff55e
Compare
|
Embarrassed that I didn't catch this with the Vagrant environment in the PR you just merged; sorry! 🥲 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some supported targets lack one or more prerequisites of the Ansible
grouptask. For instance, the commandgroupaddis absent on LibreELEC. This PR updates thegrouptask to specifyignore_errors, punting any issues with absent groups to the subsequentusertask the createskodi_user. If any groups specified inkodi_groupsare absent, then theusertask will fail.