Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat/mssql: added mssql support #144

Merged
merged 10 commits into from
Jan 2, 2025

Conversation

SysIntruder
Copy link
Contributor

Changes

  • added mssql driver support (use sqlserver in config)
  • added some parameter in config for manual parse url (current only sqlserver) for handling username/password with special characters
    • list of new parameter:
      1. Username
      2. Password
      3. Hostname
      4. Port
      5. URLParams
  • added some error check
  • added helpers/errorlist for handling multiple error (current usecase error in loop)

Related Issue

MSSQL Support
An attempt to take over this pull request

drivers/constants.go Outdated Show resolved Hide resolved
drivers/mssqql.go Outdated Show resolved Hide resolved
drivers/mssqql.go Outdated Show resolved Hide resolved
helpers/config.go Outdated Show resolved Hide resolved
helpers/errorlist/errorlist.go Outdated Show resolved Hide resolved
models/models.go Outdated Show resolved Hide resolved
@jorgerojas26
Copy link
Owner

Please check linter issues, i think we are good to merge after this.

Thanks for the PR btw, really appreciated.

@JustBarnt
Copy link

God yes, I am so excited for this to merge. My work uses MSSQL so it will be so nice to be able to use this outside of personal projects!

@jorgerojas26 jorgerojas26 merged commit 34430fb into jorgerojas26:main Jan 2, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants