Introduce a way to support user defined configurations

[svanharmelen]

This is by no means perfect, but its again taking a few small steps to make minor improvements and introduce some new functionality which I was really missing.

[svanharmelen]

Do you need anything from me in order to get this one merged?

[jorgerojas26]

Sorry for the delay (christmas). I'll try to review it as soon as i can.

[svanharmelen]

Updated as requested. Please note that depending on your OS, this is a breaking change and you will need to move your existing config file to the (potentially) new location.

[jorgerojas26]

I really don't like the breaking change. On a fresh install on MacOS, for example, the app does not work out of the box because it can't find the config file. Can we just have default values in case the file is not present?.

Also, i don't like that on macOS the config must be located in "$HOME/Library/Application Support". I'd like to keep supporting "$HOME/.config", can we search on both paths (with $HOME/.config as primary source) or maybe check for $XDG_CONFIG_HOME first?

[svanharmelen]

I really don't like the breaking change. On a fresh install on MacOS, for example, the app does not work out of the box because it can't find the config file. Can we just have default values in case the file is not present?.

Good catch! That is not how I intended it to work, of course it should work without having to first create a config file yourself (it indeed uses default values if the config file doesn't exist), so let me update that.

Also, i don't like that on macOS the config must be located in "$HOME/Library/Application Support". I'd like to keep supporting "$HOME/.config", can we search on both paths (with $HOME/.config as primary source) or maybe check for $XDG_CONFIG_HOME first?

OK so what do you suggest? Personally I think adding support for $XDG_CONFIG_HOME makes sense as it seems to be a much used way to set your preferred config dir. Making the app use $HOME/.config if that dir exists is also possible, but feels a bit less logical/expected. In that case I would almost argue to revert this part of the change all together or at least for macOS.

So to prevent multiple additional iterations, please let me know your preference.

[jorgerojas26]

I really don't like the breaking change. On a fresh install on MacOS, for example, the app does not work out of the box because it can't find the config file. Can we just have default values in case the file is not present?.

Good catch! That is not how I intended it to work, of course it should work without having to first create a config file yourself (it indeed uses default values if the config file doesn't exist), so let me update that.

Also, i don't like that on macOS the config must be located in "$HOME/Library/Application Support". I'd like to keep supporting "$HOME/.config", can we search on both paths (with $HOME/.config as primary source) or maybe check for $XDG_CONFIG_HOME first?

OK so what do you suggest? Personally I think adding support for $XDG_CONFIG_HOME makes sense as it seems to be a much used way to set your preferred config dir. Making the app use $HOME/.config if that dir exists is also possible, but feels a bit less logical/expected. In that case I would almost argue to revert this part of the change all together or at least for macOS.

So to prevent multiple additional iterations, please let me know your preference.

Thanks for the fix.

Yeah, i think supporting $XDG_CONFIG_HOME is the way.

[svanharmelen]

Updated to code to always check for a $XDG_CONFIG_HOME env var (so independent of the OS) and if that isn't set, then we fallback to the os.UserConfigDir function to get the config dir.

[jorgerojas26]

Thank you, please fix the merge conflict and we are good to go.

[svanharmelen]

Converting to a draft for just a minute to verify and double check if everything works as expected. Should only take a few minutes...

[svanharmelen]

Did find a minor bug in the pagination logic, but will make a separate PR for that. The code in this PR now seems to work as expected.

[ccoVeille]

Updated to code to always check for a $XDG_CONFIG_HOME env var (so independent of the OS) and if that isn't set, then we fallback to the os.UserConfigDir function to get the config dir.

This remind me a suggestion made here

#142 (comment)

😁😇🤣😂