Fix a copy/base bug in the query editor #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svanharmelen
force-pushed
the
fix/copy-paste
branch
2 times, most recently
from
e090009 to
14989ec
Compare
svanharmelen
force-pushed
the
fix/copy-paste
branch
from
14989ec to
66333e2
Compare
|
Please remove the version update of tview package and we are ready to merge |
|
May I ask why you don't want to update that one? As that is actually the main package that needed to be updated in order to solve the issue 😊 |
|
You are right, i'm dumb haha. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Next to the fact that pasting to the query editor was extremely slow, it also filtered out some chars like
{and}which broke queries pasted in. These things where actually already updated/fix in the used dependencies, so updating them fixed these issues.