Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak set up instructions #104

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Tweak set up instructions #104

wants to merge 4 commits into from

Conversation

github-actions[bot]
Copy link

Closes #103

README.md Outdated

If you wanted to run all of these services at once:

`docker compose --profile all up -d `
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm docker compose commands, when we have:
https://github.com/joomlatools/joomlatools-server/blob/master/bin/jtctl

Establish how to provide profile arguments into this command and remove references to docker compose

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sh bin/jtctl start

Actually loads up all available profiles:
https://github.com/joomlatools/joomlatools-server/blob/master/bin/jtctl#L183

So this issue/ Pull request is not needed

@yiendos
Copy link
Member

yiendos commented Jul 22, 2023

@johanjanssens turned out to be pretty simple in the end, the jtctl start command takes care of launching the composer profiles automatically, my bad. I did notice that in the README we make no mention of jtctl so I've amended.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tweak set up instructions
2 participants