-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Composer update joomla/database to 3.3.1 for using custom port numbers with PostgreSQL (PDO) #44781
[5.3] Composer update joomla/database to 3.3.1 for using custom port numbers with PostgreSQL (PDO) #44781
Conversation
Running Joomla installation and one Cypress test with each test case before applying the PR with current
Optional check the port forwading:
Optional check non-default port number database connections:
🟥 1/5 the PostgreSQL test failed with:
🟥 1/5 the PostgreSQL test failed with:
🟥 1/5 the PostgreSQL test failed with:
Applying this PR:
Repeating test steps 3 ... 9 Using either
the Joomla installation and Cypress tests are working with
|
Closing in favour of PR #44814 . |
Pull Request for Issue #43902 .
Summary of Changes
This pull request (PR) updates the database framework package from 3.2.1 to 3.3.1.
See https://github.com/joomla-framework/database/releases/tag/3.3.0 and https://github.com/joomla-framework/database/releases/tag/3.3.1 for the changes.
This allows Joomla to use custom port numbers with PostgreSQL (PDO) in the same way as it is already possible with MySQLi and MySQL (PDO).
The database drivers have been changes so the same logic is used for all 3 drivers used by the CMS, so for the MySQL (PDO) driver using custom port numbers works as well as before but does not rely on a more or less undocumented behaviour of the PDO database connector.
As using custom port numbers seems not to be really documented somewhere - at least not as far as I could see - there is no documentation to be updated due to this PR.
Testing Instructions
Will be added soon. Will keep in draft mode as long as not done.
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed