-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RFC] safe-mode #44765
base: 5.3-dev
Are you sure you want to change the base?
[RFC] safe-mode #44765
Conversation
administrator/components/com_admin/sql/updates/postgresql/5.3.0.2025-01.22.sql
Outdated
Show resolved
Hide resolved
@alikon nice work here. If I may I would like to propose another approach with less db stuff. We could use a reflection here to reset the plugins, in run time, similar to https://github.com/dgrammatiko/jailed-fs/blob/95444d8778e930a0360740e3b511b23bde374a5c/src/plugins/system/restrictedfs/src/Extension/RestrictedFS.php#L68-L78 You need to figure out what is essential and create the correct filter but should be an easier approach, ie not messing around with the real data in the db... Also, I would use a URL parameter, ie |
@dgrammatiko let's see 1st if it gets a consensus |
ouahhhhhh great toooool, an idea for futur add step in upgrade to switch automatic to safe mode during update and propose to disable safe mode at ending process. That can be cool to protect upgrade process |
Not sure if it helps, but HA has also such a "feature". |
RFC Pull Request for Issue #44643 .
Summary of Changes
Add a new switch in the configuration.php to enable a "Safe Mode"
when "Safe Mode" is switched on it disables all non core plugin and take a "list"
when "Safe Mode" is on it keep track of non core plugin events and update the "list"
when "Safe Mode" is switched off enable the disabled non core plugin still in the "list"
Testing Instructions
use the prebuild https://artifacts.joomla.org/drone/joomla/joomla-cms/5.3-dev/44765/downloads/81566/
enable some non core plugin
Global Configuration -> System -> Debug
set safe mode on
Extensions: Manage check that all non core plugin are disabled
enable/update/delete etc a disabled plugin all works as usual
as example unistall one
Global Configuration -> System -> Debug
set safe mode off
all the previously disabled non core plugin still in the list are enabled
Actual result BEFORE applying this Pull Request
N/A
Expected result AFTER applying this Pull Request
a switch for disable / enable non core plugins
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed