Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.3] Awesomplete accessibility fix #44756

Open
wants to merge 5 commits into
base: 5.3-dev
Choose a base branch
from

Conversation

LadySolveig
Copy link
Contributor

Pull Request followup of #39371 .

All the credits go @JackKellyUK and @dgrammatiko.

Summary of Changes

Update awesomplete package to new version and pass new language for title /aria-label attribute string to initalization.

Testing Instructions

  • Setup Smart Search > Search menu item (Smart Search > Search Suggestions global setting must be enabled)
  • Run axe browser plugin / find awesomplete list ul and check for title / aria-label attribute

Actual result BEFORE applying this Pull Request

No title / aria-label attribute present on Awesomplete list

Expected result AFTER applying this Pull Request

Title attribute present on Awesomplete list

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@LadySolveig LadySolveig requested a review from chmst as a code owner January 19, 2025 15:24
@joomla-cms-bot joomla-cms-bot added Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev labels Jan 19, 2025
@richard67 richard67 added the a11y Accessibility label Jan 19, 2025
@QuyTon
Copy link

QuyTon commented Jan 20, 2025

I have tested this item ✅ successfully on ec89bb3


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

@QuyTon
Copy link

QuyTon commented Jan 22, 2025

Use Web Developer Tools to inspect the Search Terms field element on the frontend. See aria-label attribute.

Before PR:
44756-reults-list

After PR:
44756-search-results

@fgsw
Copy link

fgsw commented Jan 22, 2025

I have tested this item ✅ successfully on 9a59b04


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

@QuyTon
Copy link

QuyTon commented Jan 22, 2025

RTC


This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756.

@joomla-cms-bot joomla-cms-bot added the RTC This Pull Request is Ready To Commit label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
a11y Accessibility Language Change This is for Translators NPM Resource Changed This Pull Request can't be tested by Patchtester PR-5.3-dev RTC This Pull Request is Ready To Commit
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants