-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[5.3] Awesomplete accessibility fix #44756
Open
LadySolveig
wants to merge
5
commits into
joomla:5.3-dev
Choose a base branch
from
LadySolveig:5.3/awesomeplete-update-fix-accessibility
base: 5.3-dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[5.3] Awesomplete accessibility fix #44756
LadySolveig
wants to merge
5
commits into
joomla:5.3-dev
from
LadySolveig:5.3/awesomeplete-update-fix-accessibility
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joomla-cms-bot
added
Language Change
This is for Translators
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.3-dev
labels
Jan 19, 2025
4 tasks
I have tested this item ✅ successfully on ec89bb3 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756. |
I have tested this item ✅ successfully on 9a59b04 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756. |
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/44756. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
a11y
Accessibility
Language Change
This is for Translators
NPM Resource Changed
This Pull Request can't be tested by Patchtester
PR-5.3-dev
RTC
This Pull Request is Ready To Commit
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request followup of #39371 .
All the credits go @JackKellyUK and @dgrammatiko.
Summary of Changes
Update awesomplete package to new version and pass new language for title /aria-label attribute string to initalization.
Testing Instructions
Smart Search > Search
menu item (Smart Search > Search Suggestions
global setting must be enabled)Actual result BEFORE applying this Pull Request
No title / aria-label attribute present on Awesomplete list
Expected result AFTER applying this Pull Request
Title attribute present on Awesomplete list
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed