Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[4.4] fix cli scheduler:run breaks if --live-site does not end with / #42864

Open
wants to merge 3 commits into
base: 4.4-dev
Choose a base branch
from

Conversation

svanschu
Copy link
Contributor

Pull Request for Issue #42859 .

Summary of Changes

Adding a check if SCRIPT_NAME starts with a / or if HTTP_HOST ends with a /
If both checks are false add a / to prevent invalid URLs

Testing Instructions

This line fails
php cli/joomla.php scheduler:run -i 1 --live-site 'http://localhost:43000'

number 1 is the rotate Logs task, but it happens with any other as well

for testing this framework PR is needed as well joomla-framework/application#123

Actual result BEFORE applying this Pull Request

grafik

Expected result AFTER applying this Pull Request

Successful run

Link to documentations

Please select:

  • Documentation link for docs.joomla.org:

  • No documentation changes for docs.joomla.org needed

  • Pull Request link for manual.joomla.org:

  • No documentation changes for manual.joomla.org needed

@HLeithner
Copy link
Member

composer update is unrelated. Beside that a url starts always with a slash so a live site looks always like https://example.com/ the last / is the identifier of the location. But I don't care if others thinks it's ok then it can be merged (wouldn't do it in 4.x branch at least)

@HLeithner HLeithner changed the title fix cli scheduler:run breaks if --live-site does not end with / [4.4] fix cli scheduler:run breaks if --live-site does not end with / Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants