Base Schema.org Implementation #6
Conversation
Update drone signature
Fix code style
shazmasiddiqui
changed the base branch from
4.3-dev
to
schema-system-plugin-test
…s/gsoc22_schema.org into schema-system-plugin-test
| * | ||
| * @since 4.0.0 | ||
| */ | ||
| protected function updateSchemaForm($data) |
There was a problem hiding this comment.
This function will update the Schema form with prefilled data from database if article already has some data.
There was a problem hiding this comment.
Please document this in the method phpdoc
plugins/schemaorg/recipe/recipe.php
Outdated
| * | ||
| * @return boolean | ||
| */ | ||
| public function onSchemaBeforeSave(AbstractEvent $event) |
There was a problem hiding this comment.
You don't need to have special function names for listeners. Offer a default subscriber map to [onSchedmaBeforeSave => saveSchema] so the schema plugin can use it in directly in getSubscribedEvents()
| * | ||
| * @since 4.0.0 | ||
| */ | ||
| protected function saveSchema(AbstractEvent $event, $form) |
There was a problem hiding this comment.
We should use a more descriptive name. An example: storeSchemaToStandardLocation() -- anything that tells the user our trait function saves the schema to the standard location.
…ions and updated schema form
| * | ||
| * @since 4.0.0 | ||
| */ | ||
| protected function addSchemaType(Form $form, $type) |
There was a problem hiding this comment.
Add return type annotation
| * | ||
| * @since 4.0.0 | ||
| */ | ||
| protected function saveSchema($event) |
There was a problem hiding this comment.
Add return type annotation
| * | ||
| * @return boolean | ||
| */ | ||
| protected function cleanupIndividualSchema(Registry $schema) |
There was a problem hiding this comment.
If this is a @todo, please mention it in a code comment.
| * | ||
| * @return boolean | ||
| */ | ||
| protected function changeDurationFormat(Registry $schema, $durationKeys) |
There was a problem hiding this comment.
A function name like normalizeDurationsToISO could be more indicative of its function.
| * | ||
| * @return boolean | ||
| */ | ||
| protected function changeDurationFormat(Registry $schema, $durationKeys) |
There was a problem hiding this comment.
Type annotation for second param and return.
| * | ||
| * @return array | ||
| */ | ||
| protected function convertToArray(Registry $schema, $repeatableFields) |
There was a problem hiding this comment.
Clarify why we need this function and document an example of the transformation it's performing in the phpdoc comment.
| * | ||
| * @return boolean | ||
| */ | ||
| public function onSchemaAfterSave(AbstractEvent $event) |
There was a problem hiding this comment.
You do not need the onXXX functions. Map the functions to events in getSubscribedEvents() instead.
| } | ||
| } | ||
| } | ||
| $schema->toArray(); |
There was a problem hiding this comment.
Why are returning the schema as an array?
rjharishabh
force-pushed
the
schemaorg-plugin-trait
branch
from
a5a2ed8
to
cfff800
Compare
Service interface
Organization schema
Pull Request for Issue #5