[4.1] Fix form label relation removed title from non active elements #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Krshivam25
changed the title
bembelimen
pushed a commit
that referenced
this pull request
May 8, 2022
…ler-sql-improvements-mod-1 [CMS PR 36506] Branch update and merge conflicts resolution
bembelimen
pushed a commit
that referenced
this pull request
May 8, 2022
* [3.10] [PHP 8.1] Mysqli database driver escapt function fix Fixes `Deprecated: mysqli_real_escape_string(): Passing null to parameter #2 ($string) of type string is deprecated in libraries/joomla/database/driver/mysqli.php on line 254` * Fix also the other db drivers Co-authored-by: Richard Fath <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: 1.Title on Non-Active Element. Which keyboard-only users and touch-only users will be unable to see the title content.
2. A checkbox or radio button uses nesting for the label text but is missing the for/id relationship. Some screen readers will not read this correctly.
Summary of Changes: 1.Removed the title found on the non-active element.
2. Provide a matching for/id relationship between the label and the input.