Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalidate file cache upon copying folders #74

Open
wants to merge 1 commit into
base: 3.x-dev
Choose a base branch
from
Open

Invalidate file cache upon copying folders #74

wants to merge 1 commit into from

Conversation

janschoenherr
Copy link

@janschoenherr janschoenherr mentioned this pull request Jan 24, 2025
Open
4 tasks
@Llewellynvdm
Copy link

Llewellynvdm commented Jan 29, 2025 •
edited
Loading

Can we make this behavior optional? Instead of always performing this action, we could introduce an alternative method or an additional argument in the copy method to allow developers to enable or disable it as needed.

@janschoenherr
Copy link
Author

janschoenherr commented Jan 30, 2025 •
edited
Loading

@Llewellynvdm WordPress seems to be doing that. They have a separate function move_dir() which does the invalidation, while the base filesystem does not.

For me it's just a concern, that the Installer Adapters in Joomla do not seem to invalidate the opcache after copying the files through Folder::move().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@janschoenherr @Llewellynvdm