Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

complete refactor #36

Open
wants to merge 28 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
1aab392
complete refactor
jonschlinkert Mar 31, 2018
83cbeae
params example
jonschlinkert Apr 13, 2018
91de81b
lazy utils
jonschlinkert Apr 13, 2018
d5ee017
lint, update tests
jonschlinkert Apr 28, 2018
208a0ac
move view utils to ./utils
jonschlinkert May 4, 2018
010adf7
examples, benchmarks
jonschlinkert May 4, 2018
740118f
don't recompile view if view.fn exists
jonschlinkert May 5, 2018
56d3587
add `.reset()` to view
jonschlinkert May 5, 2018
9b3dac1
some basic benchmarks
jonschlinkert May 5, 2018
c49c685
add recompile option
jonschlinkert May 5, 2018
d285af8
sync rendering, pre-compiling
jonschlinkert May 6, 2018
e4c6f58
layouts and partials
jonschlinkert May 8, 2018
61aa0ed
collection lookups, layouts, engines
jonschlinkert May 8, 2018
20be6c7
work on plugins, optimizations
jonschlinkert May 10, 2018
521cf5b
add benchmarks, test
jonschlinkert May 13, 2018
0c3b401
pagination
jonschlinkert May 22, 2018
1d59849
remove async code
jonschlinkert Jun 6, 2018
dd17eda
add pagination generator/benchmarks
jonschlinkert Jun 11, 2018
3c31759
streams support
jonschlinkert Jul 2, 2018
6f5a83e
unit tests, pagination, collections
jonschlinkert Jul 12, 2018
d5a4b30
add file class
jonschlinkert Jul 29, 2018
e7e28ee
revert to async
jonschlinkert Aug 19, 2018
217ec93
rename view to file
jonschlinkert Sep 5, 2018
4b4df2e
lint, coverage
jonschlinkert Nov 11, 2018
8b8cad7
clean up
jonschlinkert Nov 11, 2018
9b1fe82
examples, tests, docs
jonschlinkert Dec 10, 2018
8e082b8
adds tests, makes tests strict
jonschlinkert Jun 28, 2019
c0d3e42
several improvements
jonschlinkert Jun 28, 2019
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .editorconfig
Original file line number Diff line number Diff line change
@@ -1,13 +1,14 @@
# http://editorconfig.org/
root = true

[*]
indent_style = space
end_of_line = lf
charset = utf-8
end_of_line = lf
indent_size = 2
trim_trailing_whitespace = true
indent_style = space
insert_final_newline = true
trim_trailing_whitespace = true

[{**/{actual,fixtures,expected,templates}/**,*.md}]
trim_trailing_whitespace = false
insert_final_newline = false
insert_final_newline = false
16 changes: 12 additions & 4 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
{
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true
},
"extends": [
"eslint:recommended"
],

"env": {
"browser": false,
Expand All @@ -11,6 +10,15 @@
"mocha": true
},

"parserOptions":{
"ecmaVersion": 9,
"sourceType": "module",
"ecmaFeatures": {
"modules": true,
"experimentalObjectRestSpread": true
}
},

"globals": {
"document": false,
"navigator": false,
Expand Down
11 changes: 1 addition & 10 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,10 +1 @@
# Enforce Unix newlines
* text eol=lf

# binaries
*.ai binary
*.psd binary
*.jpg binary
*.gif binary
*.png binary
*.jpeg binary
* text=auto
85 changes: 85 additions & 0 deletions .github/contributing.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,85 @@
# Contributing to metaloid-simple

First and foremost, thank you! We appreciate that you want to contribute to metaloid-simple, your time is valuable, and your contributions mean a lot to us.

## Important!

By contributing to this project, you:

* Agree that you have authored 100% of the content
* Agree that you have the necessary rights to the content
* Agree that you have received the necessary permissions from your employer to make the contributions (if applicable)
* Agree that the content you contribute may be provided under the Project license(s)

## Getting started

**What does "contributing" mean?**

Creating an issue is the simplest form of contributing to a project. But there are many ways to contribute, including the following:

- Updating or correcting documentation
- Feature requests
- Bug reports

If you'd like to learn more about contributing in general, the [Guide to Idiomatic Contributing](https://github.com/jonschlinkert/idiomatic-contributing) has a lot of useful information.

**Showing support for metaloid-simple**

Please keep in mind that open source software is built by people like you, who spend their free time creating things the rest the community can use.

Don't have time to contribute? No worries, here are some other ways to show your support for metaloid-simple:

- star the [project](https://github.com/jonschlinkert/metaloid-simple)
- tweet your support for metaloid-simple

## Issues

### Before creating an issue

Please try to determine if the issue is caused by an underlying library, and if so, create the issue there. Sometimes this is difficult to know. We only ask that you attempt to give a reasonable attempt to find out. Oftentimes the readme will have advice about where to go to create issues.

Try to follow these guidelines

- **Avoid creating issues for implementation help**. It's much better for discoverability, SEO, and semantics - to keep the issue tracker focused on bugs and feature requests - to ask implementation-related questions on [stackoverflow.com][so]
- **Investigate the issue**:
- **Check the readme** - oftentimes you will find notes about creating issues, and where to go depending on the type of issue.
- Create the issue in the appropriate repository.

### Creating an issue

Please be as descriptive as possible when creating an issue. Give us the information we need to successfully answer your question or address your issue by answering the following in your issue:

- **version**: please note the version of metaloid-simple are you using
- **extensions, plugins, helpers, etc** (if applicable): please list any extensions you're using
- **error messages**: please paste any error messages into the issue, or a [gist](https://gist.github.com/)

### Closing issues

The original poster or the maintainer's of metaloid-simple may close an issue at any time. Typically, but not exclusively, issues are closed when:

- The issue is resolved
- The project's maintainers have determined the issue is out of scope
- An issue is clearly a duplicate of another issue, in which case the duplicate issue will be linked.
- A discussion has clearly run its course


## Next steps

**Tips for creating idiomatic issues**

Spending just a little extra time to review best practices and brush up on your contributing skills will, at minimum, make your issue easier to read, easier to resolve, and more likely to be found by others who have the same or similar issue in the future. At best, it will open up doors and potential career opportunities by helping you be at your best.

The following resources were hand-picked to help you be the most effective contributor you can be:

- The [Guide to Idiomatic Contributing](https://github.com/jonschlinkert/idiomatic-contributing) is a great place for newcomers to start, but there is also information for experienced contributors there.
- Take some time to learn basic markdown. We can't stress this enough. Don't start pasting code into GitHub issues before you've taken a moment to review this [markdown cheatsheet](https://gist.github.com/jonschlinkert/5854601)
- The GitHub guide to [basic markdown](https://help.github.com/articles/markdown-basics/) is another great markdown resource.
- Learn about [GitHub Flavored Markdown](https://help.github.com/articles/github-flavored-markdown/). And if you want to really go above and beyond, read [mastering markdown](https://guides.github.com/features/mastering-markdown/).

At the very least, please try to:

- Use backticks to wrap code. This ensures that it retains its formatting and isn't modified when it's rendered by GitHub, and makes the code more readable to others
- When applicable, use syntax highlighting by adding the correct language name after the first "code fence"


[so]: http://stackoverflow.com/questions/tagged/metaloid-simple
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
# always ignore files
*.DS_Store
.idea
.vscode
*.sublime-*

# test related, or directories generated by tests
Expand Down
1 change: 1 addition & 0 deletions .npmrc
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
package-lock=false
11 changes: 3 additions & 8 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,11 +5,6 @@ os:
language: node_js
node_js:
- node
- '8'
- '7'
- '6'
- '5'
- '4'
matrix:
allow_failures:
- node_js: '4'
- '10'
- '9'
- '8.6'
Loading