Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI #5

Merged
merged 8 commits into from
Jun 1, 2022
Merged

Improve CI #5

Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
e76acec
Improve CI
jonjozwiak Jun 1, 2022
6fd98d4
Add multiple OS targets
jonjozwiak Jun 1, 2022
7e843b0
Update node.js.yml
jonjozwiak Jun 1, 2022
dfe3507
Add artifact upload
jonjozwiak Jun 1, 2022
050589d
Update .github/workflows/node.js.yml
jonjozwiak Jun 1, 2022
c73be3a
Added download artifact to gh action
jonjozwiak Jun 1, 2022
fd92756
Update node.js.yml
jonjozwiak Jun 1, 2022
1239dfa
Fixing GH Action
jonjozwiak Jun 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 24 additions & 13 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,29 +3,40 @@

name: Node.js CI

on:
push:
branches: [ main ]
pull_request:
branches: [ main ]
on: [push]

jobs:
build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- name: npm install and build webpack
run: |
jonjozwiak marked this conversation as resolved.
Show resolved Hide resolved
npm install
npm run build
- uses: actions/upload-artifact@main
with:
name: webpack artifacts
path: public/

test:

runs-on: ubuntu-latest

strategy:
matrix:
node-version: [12.x, 14.x, 16.x]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can commit this suggestion directly.

Suggested change
node-version: [12.x, 14.x, 16.x]
- uses: actions/download-artifact@main
with:
name: webpack artifacts
path: public
- name: npm install, and test

# See supported Node.js release schedule at https://nodejs.org/en/about/releases/
os: [ubuntu-latest, windows-2016]
node-version: [12.x, 14.x]
jonjozwiak marked this conversation as resolved.
Show resolved Hide resolved

steps:
- uses: actions/checkout@v3
- uses: actions/checkout@v2
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v3
uses: actions/setup-node@v1
with:
node-version: ${{ matrix.node-version }}
cache: 'npm'
- run: npm ci
- run: npm run build --if-present
- run: npm test
- name: npm install, and test
run: |
npm install
npm test
env:
CI: true