Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context name when getting it from the registry #604

Merged
merged 1 commit into from
Jan 27, 2025
Merged

Conversation

lyrixx
Copy link
Member

@lyrixx lyrixx commented Jan 27, 2025

fix #592

src/Context.php Outdated
@@ -270,6 +273,10 @@ public function withVerbosityLevel(VerbosityLevel|LegacyVerbosityLevel $verbosit
);
}

/**
* @internal
* Do not use this argument, it is only used internally by the application
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Do not use this argument, it is only used internally by the application
* Do not use this method, it is only used internally by the application

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, fixed

Copy link
Member

@pyrech pyrech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and welcome back 🎉

@pyrech pyrech merged commit 3ef01f2 into main Jan 27, 2025
10 checks passed
@pyrech pyrech deleted the context-name branch January 27, 2025 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Context name not populated when manually triggering the context
2 participants