Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add UTF8 BOM #17

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add UTF8 BOM #17

wants to merge 2 commits into from

Conversation

dfang
Copy link

@dfang dfang commented Jun 19, 2019

add utf-8 bom to the new created file, so you don't need to change the encoding for the file contains chinese text

@dfang
Add UTF-8 BOM
9e4846b 
Add UTF-8 BOM for the chinese csv file
@dfang
Merge pull request #1 from dfang/utf8-bom
f931de1 
Add UTF-8 BOM
@dfang
Copy link
Author

dfang commented Jun 19, 2019

It breaks TestWriteFile in travis ci, but it works as expected. i checked the file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@dfang