Added missing e.stopImmediatePropagation() call in tap handlers.

Otherwise, this leaked event causes issues when this component is loaded inside a `<paper-drawer-panel>`. PolymerElements/paper-drawer-panel#92
johnyanarella · Feb 8, 2017 · ed12942 · ed12942
1 parent 4f6a658
commit ed12942
Show file tree

Hide file tree

Showing 5 changed files with 20 additions and 6 deletions.
diff --git a/radium-filter-autocomplete-list.html b/radium-filter-autocomplete-list.html
@@ -42,7 +42,7 @@
             <div class="value-label" title="[[_getFilterValueLabelForValue(filterValues, item)]]">
               [[_getFilterValueLabelForValue(filterValues, item)]]
             </div>
-            <iron-icon icon="cancel" on-tap="_removeValueClick"></iron-icon>
+            <iron-icon icon="cancel" on-tap="_removeValueTap"></iron-icon>
           </div>
         </template>
       </div>
@@ -133,7 +133,9 @@
         }
       },
 
-      _removeValueClick: function (e) {
+      _removeValueTap: function (e) {
+        e.stopPropagation();
+
         var valueToRemove = e.model.__data__.item;
 
         this.value = (this.value || []).filter(function (value) {

diff --git a/radium-filter-autocomplete.html b/radium-filter-autocomplete.html
@@ -301,6 +301,8 @@
       },
 
       _onClearIconTap: function() {
+        e.stopPropagation();
+
         this.value = '';
         this.cancelDebouncer('input');
         this.fire('change');
@@ -372,6 +374,8 @@
       },
 
       _onSuggestionItemTap: function(e) {
+        e.stopPropagation();
+
         var selectedSuggestion = this._suggestions[e.currentTarget.value];
         this.value = selectedSuggestion.label;
         this._isDirty = false;

diff --git a/radium-filter-bar.html b/radium-filter-bar.html
@@ -193,11 +193,15 @@
         }.bind(this));
       },
 
-      _clearAllClicked: function() {
+      _clearAllClicked: function(evt) {
+        evt.stopPropagation();
+
         this.removeAllTerms();
       },
 
       _termClicked: function(evt) {
+        evt.stopPropagation();
+
         var term = JSON.parse(evt.currentTarget.getAttribute('data-term'));
         this.removeTerm(term.key, term.value);
       }

diff --git a/radium-filter-dropdown-list.html b/radium-filter-dropdown-list.html
@@ -40,7 +40,7 @@
         <template is="dom-repeat" items="[[value]]">
           <div class="value-row">
             <div class="value-label" title="[[_getOptionLabelForValue(options, item)]]">[[_getOptionLabelForValue(options, item)]]</div>
-            <iron-icon icon="cancel" on-tap="_removeValueClick"></iron-icon>
+            <iron-icon icon="cancel" on-tap="_removeValueTap"></iron-icon>
           </div>
         </template>
       </div>
@@ -116,7 +116,9 @@
         }
       },
 
-      _removeValueClick: function(e) {
+      _removeValueTap: function(e) {
+        e.stopPropagation();
+
         var valueToRemove = e.model.__data__.item;
 
         this.value = (this.value || []).filter(function(value) {

diff --git a/radium-filter-panel.html b/radium-filter-panel.html
@@ -139,7 +139,9 @@
           collapse.id = 'filter' + filterIndex;
           collapse.setAttribute('opened', 'true');
 
-          label.addEventListener('click', function() {
+          label.addEventListener('click', function(evt) {
+            evt.stopPropagation();
+
             collapse.toggle();
           });