설치 안내문 업데이트 #51
Open
설치 안내문 업데이트 #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johngrib
reviewed
Mar 3, 2024
| ``` | ||
|
|
||
| skeleton을 fork한 원격저장소를 clone하고 | ||
| 해당 폴더로 이동합시다. |
There was a problem hiding this comment.
'폴더'보다 '디렉토리'를 사용해 주세요.
Suggested change
| 해당 폴더로 이동합시다. | |
| 해당 디렉토리로 이동합시다. |
Comment on lines
+35
to
+40
| ```bash | ||
| $ git clone https://github.com/rbenv/ruby-build.git "$(rbenv root)"/plugins/ruby-build | ||
| $ sudo apt-get install libffi-dev | ||
| $ sudo apt-get install libyaml-dev | ||
| $ rbenv install 3.2.3 | ||
| ``` |
There was a problem hiding this comment.
macOS 사용자(저)를 위한 방법으로 brew install rbenv를 사용하는 방법을 추가해주면 좋겠습니다.
만약 macOS 컴퓨터 사용이 곤란해서 관련 내용을 추가하기 어렵다면 말씀해주세요. 제가 추가하면 됩니다.
| export PATH="$HOME/.gems/bin:$PATH" | ||
| ``` | ||
|
|
||
| skeleton을 fork한 원격저장소를 clone하고 |
There was a problem hiding this comment.
clone을 언급하게 되었으므로 git clone 명령도 여기에서 소개해주는 것이 바람직할 것 같습니다.
There was a problem hiding this comment.
업데이트를 한 후 리뷰 요청 드리겠습니다!
install.sh를 준비하고 싶어서 한참 뒤에 요청이 업데이트 될 거 같습니다.
자세하게 리뷰해주셔서 감사합니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
이전에 이슈를 등록했었는데
풀 리퀘스트도 해보고 싶어서 요청드렸습니다.
새 아이디를 하나 만들어서 설치 과정을 다시 진행하고
녹화한 영상을 보면서 작업 순서대로 적어봤습니다.