-
-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
features/Doc processor #504
base: master
Are you sure you want to change the base?
Conversation
Define interfaces that the pdf generator will depend on
create component package add generate method in component mappers
refactor document to allow defining page lists
create a factory that wrapper the creation of components to facilitate the creation of unit tests
fix page list creation use abstract factory to create components
Rename interfaces to non-names not used by Maroto
The list should allow applying list behavior to any component
refactor load external images
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #504 +/- ##
==========================================
- Coverage 87.94% 81.73% -6.21%
==========================================
Files 61 96 +35
Lines 2330 3864 +1534
==========================================
+ Hits 2049 3158 +1109
- Misses 246 609 +363
- Partials 35 97 +62
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I've marked this PR as a draft since I still need to work on the documentation and add more tests. I'd also appreciate any feedback on the feature. |
Description
This feature enables the generation of PDFs from serialized documents. To achieve this, the PDF template creation process is decoupled from the document generation, as outlined in RFC.
Related Issue
#390
Checklist
func (<first letter of struct> *struct) method() {}
name style.when,should
naming pattern.m := mocks.NewConstructor(t)
.m.EXPECT().MethodName()
method to mock methods.example_test.go
.make dod
with none issues pointed out bygolangci-lint