Use non-capturing groups for IPv4 address detection. #323
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are not using the captured groups, we can replace them with non-capturing groups as a micro-op. Benchmarks indicate about 10-20% improvement in parsing speed for positive matches.
Using the
re.ASCII
flag appears to have slight speed boost for CPython, but makes things slower on PyPy for certain inputs.Results are mixed for bracketless-IPv6 addresses.
CPython 3.11
PyPy 3.9