epics-base#117 Check Status.getStackDump() is non-empty before use

This check is already used in methods such as BlockingServerTCPTransport#authenticationCompleted.
joeshannon · Sep 6, 2021 · b6aa5a8 · b6aa5a8
1 parent 3a32ca5
commit b6aa5a8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/pvAccessJava/src/org/epics/pvaccess/client/rpc/RPCClientImpl.java b/pvAccessJava/src/org/epics/pvaccess/client/rpc/RPCClientImpl.java
@@ -129,10 +129,11 @@ public PVStructure request(PVStructure pvArgument, double timeout)
 					return result;
 				else
 				{
-					if (status.getStackDump() == null)
-						throw new RPCRequestException(status.getType(), status.getMessage());
+					String stackDump = status.getStackDump();
+					if (stackDump != null && !stackDump.isEmpty())
+						throw new RPCRequestException(status.getType(), status.getMessage() + ", cause:\n" + stackDump);
 					else
-						throw new RPCRequestException(status.getType(), status.getMessage() + ", cause:\n" + status.getStackDump());
+						throw new RPCRequestException(status.getType(), status.getMessage());
 				}
 			}
 			else

diff --git a/pvAccessJava/src/org/epics/pvaccess/server/impl/remote/rpc/ServerRPCService.java b/pvAccessJava/src/org/epics/pvaccess/server/impl/remote/rpc/ServerRPCService.java
@@ -288,7 +288,8 @@ public PVStructure execute() throws RPCRequestException {
 			if (!status.isSuccess())
 			{
 				String errorMessage = "failed to fetch channel list: " + status.getMessage();
-				if (status.getStackDump() != null)
+				String stackDump = status.getStackDump();
+				if (stackDump != null && !stackDump.isEmpty())
 					errorMessage += "\n" + status.getStackDump();
 				throw new RPCRequestException(StatusType.ERROR, errorMessage);
 			}