[CSharp] : Increase robustness - Block AST #5284
Open
+39
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix methodFullName inside using block * code refactoring * Try handling change * added curly braces
|
@ankit-privado can you add more details/description to this PR |
DavidBakerEffendi
requested changes
Feb 4, 2025
| @@ -173,4 +173,37 @@ class ControlStructureTests extends CSharpCode2CpgFixture { | |||
|
|
|||
| } | |||
|
|
|||
| "having using statement" should { | |||
There was a problem hiding this comment.
Suggested change
| "having using statement" should { | |
| "a variable defined within a using statement" should { |
| |} | ||
| |""".stripMargin) | ||
|
|
||
| "resolve methodFullName" in { |
There was a problem hiding this comment.
Suggested change
| "resolve methodFullName" in { | |
| "partially resolve calls on the defined variable" in { |
| @@ -362,11 +362,13 @@ trait AstForStatementsCreator(implicit withSchemaValidation: ValidationMode) { t | |||
| * Thus, this is lowered as a try-finally, with finally making a call to `Dispose` on the declared variable. | |||
| */ | |||
| private def astForUsingStatement(usingStmt: DotNetNodeInfo): Seq[Ast] = { | |||
| val tryNode = controlStructureNode(usingStmt, ControlStructureTypes.TRY, code(usingStmt)) | |||
| val tryNode = controlStructureNode(usingStmt, ControlStructureTypes.TRY, code(usingStmt)) | |||
| val declAst = Try(createDotNetNodeInfo(usingStmt.json(ParserKeys.Declaration))) match { | |||
There was a problem hiding this comment.
Given we throw away the exception, rather lets do something like
Suggested change
| val declAst = Try(createDotNetNodeInfo(usingStmt.json(ParserKeys.Declaration))) match { | |
| val declAst = Try(createDotNetNodeInfo(usingStmt.json(ParserKeys.Declaration))).map(astForNode).getOrElse(Seq.empty[Ast]) |
|
@khemrajrathore this PR was to handle code inside the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.