Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/python3 -- resurrecting @wackywendell's python 3 support branch. #11

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

joe-jordan
Copy link
Owner

A little while ago @wackywendell kindly made a couple of small changes for python three support and added some unit tests.

Here, I am finally adding these to the main repo. Will keep this as a PR while I check over the unit tests and code coverage.

@joe-jordan
Copy link
Owner Author

coverage gaps:

  • numpy array inputs
  • periodic boundary conditions
  • with/without radii
  • trigger voro++ error "number of cells not equal to the number of input particles" (I think this is triggered when a particle is on one of the walls, or outside the bounds?)

@joe-jordan
Copy link
Owner Author

Also, noticed that the Cython function has mutable arg defaults. It doesn't mutate them, but this should be fixed anyway.

@wackywendell
Copy link

Hi! Glad you were interested in doing this. Just thought I'd give you a heads up: I also wrote tess (docs here), which is another interface for voro++ with a more object-oriented interface. But its nice to also see pyvoro getting python 3 support!

@wackywendell wackywendell mentioned this pull request Oct 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants