Fix invalid plan modifications

joaquimmmagalhaes · Jul 14, 2021 · 9da2baa · 9da2baa
1 parent e53c111
commit 9da2baa
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/internal/schemas/resources/admin/mapping.go b/internal/schemas/resources/admin/mapping.go
@@ -26,6 +26,7 @@ func convertFromMapToAdminStruct(d *schema.ResourceData) models.Admin {
 		admin.Permissions[i] = permission.(string)
 	}
 
+	admin.Filters = models.AdminFilters{}
 	filters := d.Get("filters").([]interface{})
 	if len(filters) > 0 {
 		filters := filters[0].(map[string]interface{})

diff --git a/internal/schemas/resources/admin/resource.go b/internal/schemas/resources/admin/resource.go
@@ -105,8 +105,11 @@ func get(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagno
 		return diag.FromErr(err)
 	}
 
-	if err := d.Set("filters", flattenFilters(admin.Filters)); err != nil {
-		return diag.FromErr(err)
+	// Double validation
+	if len(admin.Filters.AllowList) > 0 {
+		if err := d.Set("filters", flattenFilters(admin.Filters)); err != nil {
+			return diag.FromErr(err)
+		}
 	}
 
 	if err := d.Set("additional_info", admin.AdditionalInfo); err != nil {
@@ -118,7 +121,10 @@ func get(ctx context.Context, d *schema.ResourceData, m interface{}) diag.Diagno
 
 func flattenFilters(filters models.AdminFilters) []interface{} {
 	transformed := make(map[string]interface{})
-	transformed["allow_list"] = filters.AllowList
+
+	if len(filters.AllowList) > 0 {
+		transformed["allow_list"] = filters.AllowList
+	}
 
 	return []interface{}{transformed}
 }