ref(types): remove register offset field from BaoIoRequest

This commit removes the register offset (reg_off) field from BaoIoRequest struct since we already have the full address (addr field). Signed-off-by: joaopeixoto13 <[email protected]>
joaopeixoto13 · May 5, 2024 · 904ec8a · 904ec8a
1 parent 80b8d0c
commit 904ec8a
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 5 deletions.
diff --git a/src/api/src/device_model.rs b/src/api/src/device_model.rs
@@ -155,7 +155,6 @@ impl BaoDeviceModel {
         // Create a new I/O request
         let mut request = BaoIoRequest {
             virtio_id: 0,
-            reg_off: 0,
             addr: 0,
             op: BAO_IO_ASK,
             value: 0,

diff --git a/src/api/src/ioctl.rs b/src/api/src/ioctl.rs
@@ -95,8 +95,8 @@ mod tests {
         assert_eq!(0x0000_A603, BAO_IOCTL_IO_CREATE_CLIENT());
         assert_eq!(0x0000_A604, BAO_IOCTL_IO_DESTROY_CLIENT());
         assert_eq!(0x0000_A605, BAO_IOCTL_IO_ATTACH_CLIENT());
-        assert_eq!(0xC048_A606, BAO_IOCTL_IO_REQUEST());
-        assert_eq!(0x4048_A607, BAO_IOCTL_IO_REQUEST_NOTIFY_COMPLETED());
+        assert_eq!(0xC040_A606, BAO_IOCTL_IO_REQUEST());
+        assert_eq!(0x4040_A607, BAO_IOCTL_IO_REQUEST_NOTIFY_COMPLETED());
         assert_eq!(0x0000_A608, BAO_IOCTL_IO_NOTIFY_GUEST());
         assert_eq!(0x4020_A609, BAO_IOCTL_IOEVENTFD());
         assert_eq!(0x4008_A60A, BAO_IOCTL_IRQFD());

diff --git a/src/api/src/types.rs b/src/api/src/types.rs
@@ -14,7 +14,6 @@ use serde::{Deserialize, Serialize};
 /// # Attributes
 ///
 /// * `virtio_id` - Virtio instance ID.
-/// * `reg_off` - Register offset.
 /// * `addr` - Address.
 /// * `op` - Operation.
 /// * `value` - Value.
@@ -26,7 +25,6 @@ use serde::{Deserialize, Serialize};
 #[derive(Debug)]
 pub struct BaoIoRequest {
     pub virtio_id: u64,
-    pub reg_off: u64,
     pub addr: u64,
     pub op: u64,
     pub value: u64,