Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSV gem as a dependency for Ruby 3.4 #796

Merged
merged 1 commit into from
Feb 17, 2024
Merged

Add CSV gem as a dependency for Ruby 3.4 #796

merged 1 commit into from
Feb 17, 2024

Conversation

ngan
Copy link
Contributor

@ngan ngan commented Feb 14, 2024

In Ruby 3.4, the csv gem will not be a default gem. Since httparty uses CSV directly, we should add it as a gem dependency.

/usr/local/bundle/ruby/3.3.0/gems/httparty-0.21.0/lib/httparty.rb:10: warning: csv was loaded from the standard library, but will no longer be part of the default gems since Ruby 3.4.0. Add csv to your Gemfile or gemspec. Also contact author of httparty-0.21.0 to add csv into its gemspec.

@ngan
Copy link
Contributor Author

ngan commented Feb 16, 2024

@jnunemaker friendly bump. Let me know if there's anything else to be done for this. Thanks!

@jnunemaker jnunemaker merged commit 36c31e0 into jnunemaker:master Feb 17, 2024
8 checks passed
@ngan ngan deleted the add-csv-gem branch February 17, 2024 22:28
@mishina2228 mishina2228 mentioned this pull request Apr 24, 2024
Closed
@dreyks dreyks mentioned this pull request May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ngan @jnunemaker