Adapt pointer to closure #347
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello! I missed this PR in August, sorry about that! What you have here looks pretty good! Do you think you can provide a test case or example to help me verify this change locally? We have a set of tests in jnr-ffi that should give you an idea how to handle this. |
|
I will take a look over the weekend if I can add a test case for this change. |
|
@headius, I have added a simple test case. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When implementing an integration with the libfuse I noticed that the readdir callback supplies the user with a fuse_fill_dir_t that is a pointer to a function that supposed to be called for every child item in the directory.
I have not found a way to automatically nor programmatically convert that pointer to a closure so that it could be called within java.
I believe others implementations might have a similar issue that required a split package to fix.
This change adds a similar implementation to the ClosureManager/NativeClosureManager so that the pointer could be adapted to the interface callable from java.
I am new to the
jnr-ffilib. Please let me know if I miss anything or if it is a right way to resolve this issue.Thanks!