Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve issues on workflows #218

Merged
merged 16 commits into from
Jan 28, 2025
Merged

Resolve issues on workflows #218

merged 16 commits into from
Jan 28, 2025

Conversation

jmuelbert
Copy link
Owner

Description

Not all issues on workflow cleaned.

  • Resolve many issues
  • remove unusable workflows
  • remove double actions.
    • eg. checks in pre-commit trunk.io

Related Issues / Pull Requests

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Checklist

  • If the key of a setting is changed, the old attribute is updated or
    it is resolved in SettingsUpdater.
  • If needed, I have opened a pull request or an issue to update the
    documentation.
  • If these changes are notable, they are documented in
    CHANGELOG.md.

Additional text

jmuelbert added 6 commits May 18, 2024 11:40
  extends: ['@commitlint/config-conventional'],
  rules: {
    // Here you can add custom rules or override the default ones
    'type-enum': [
      2, 'always', [
        'feat', // new feature
        'fix', // bug fix
        'docs', // documentation only changes
        'style', // formatting, missing semi colons, etc; no code change
        'refactor', // refactoring production code
        'test', // adding tests, refactoring test; no production code change
        'chore', // updating grunt tasks etc; no production code change
      ]
    ],
    // You can also specify the scopes you use
    'scope-enum': [
      2, 'always', [
        'auth', // authentication related changes
        'api', // API related changes
        'models', // database models changes
        'views', // frontend views changes
        'utils', // utility functions and helpers
        // Add more scopes here
      ]
    ],
    // Other rules...
  }
};
ml
Copy link

trunk-io bot commented May 30, 2024

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

Copy link

github-actions bot commented May 30, 2024

Dependency Review

The following issues were found:

  • ❌ 2 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ✅ 0 package(s) with unknown licenses.
  • ⚠️ 4 packages with OpenSSF Scorecard issues.

View full job summary

.github/workflows/ci.yml Fixed Show fixed Hide fixed

- name: Install Hatch
run: pip install --upgrade hatch

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: pipCommand not pinned by hash
Click Remediation section below to solve this issue
.github/workflows/ci.yml Fixed Show fixed Hide fixed

- name: Install Hatch
run: pip install --upgrade hatch

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: pipCommand not pinned by hash
Click Remediation section below to solve this issue
.github/workflows/ci.yml Fixed Show fixed Hide fixed

- name: Install Hatch
run: pip install --upgrade hatch

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: pipCommand not pinned by hash
Click Remediation section below to solve this issue
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Solved

.github/workflows/ci.yml Fixed Show resolved Hide resolved

- name: Install Hatch
run: pip install --upgrade hatch

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: pipCommand not pinned by hash
Click Remediation section below to solve this issue
.github/workflows/ci.yml Fixed Show resolved Hide resolved

- name: Install Hatch
run: pip install --upgrade hatch

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: pipCommand not pinned by hash
Click Remediation section below to solve this issue
Copy link

github-actions bot commented May 30, 2024

Here are some friendly prose warnings from write-good:

In ./SECURITY.md
=============
 the moment checkconnect only considers the very latest commit to be
                         ^^^^
"only" can weaken meaning on line 5 at column 27
-------------
nnect only considers the very latest commit to be
                         ^^^^
"very" is a weasel word and can weaken meaning on line 5 at column 46
-------------
he very latest commit to be
                         ^^^^^^^^^^^^
"be
supported" may be passive voice on line 5 at column 68
-------------
automated updates to minimize the time between vulnerability publication
                     ^^^^^^^^
"minimize" is wordy or unneeded on line 7 at column 21
-------------
In the near future we will introduce versioning, so expect this section to
^^^^^^^^^^^^^^^^^^
"In the near future" is wordy or unneeded on line 15 at column 0


In ./AUTHORS.md
=============
or without modification, are
                         ^^^^^^^^^^^^^
"are
permitted" may be passive voice on line 7 at column 69
-------------
this notice are preserved.
            ^^^^^^^^^^^^^
"are preserved" may be passive voice on line 9 at column 12


In ./CHANGELOG.md
=============
ges to this project will be documented in this file.
                         ^^^^^^^^^^^^^
"be documented" may be passive voice on line 3 at column 41
-------------
The format is based on
           ^^^^^^^^
"is based" may be passive voice on line 5 at column 11


In ./.github/CODE_OF_CONDUCT.md
=============
- Giving and gracefully accepting constructive feedback
             ^^^^^^^^^^
"gracefully" can weaken meaning on line 22 at column 13
-------------
sing on what is best not just for us as individuals, but for the
                         ^^^^
"just" can weaken meaning on line 25 at column 31
-------------
  overall community
  ^^^^^^^
"overall" is wordy or unneeded on line 26 at column 2
-------------
t which could reasonably be considered inappropriate in a
                         ^^^^^^^^^^^^^
"be considered" may be passive voice on line 37 at column 39
-------------
nacceptable behavior may be
                         ^^^^^^^^^^^
"be
reported" may be passive voice on line 62 at column 72
-------------
il]. All complaints will be reviewed and
                         ^^^^^^^^^^^
"be reviewed" may be passive voice on line 64 at column 51
-------------
investigated promptly and fairly.
             ^^^^^^^^
"promptly" can weaken meaning on line 65 at column 13
-------------
nvestigated promptly and fairly.
                         ^^^^^^
"fairly" is a weasel word and can weaken meaning on line 65 at column 26
-------------
All community leaders are obligated to respect the privacy and security of
                      ^^^^^^^^^^^^^
"are obligated" may be passive voice on line 67 at column 22
-------------
te. A public apology may be requested.
                         ^^^^^^^^^^^^
"be requested" may be passive voice on line 83 at column 57
-------------
ing the Code of Conduct, is allowed during
                         ^^^^^^^^^^
"is allowed" may be passive voice on line 105 at column 54
-------------
This Code of Conduct is adapted from the [Contributor Covenant][homepage],
                     ^^^^^^^^^^
"is adapted" may be passive voice on line 120 at column 21
-------------
munity Impact Guidelines were inspired by
                         ^^^^^^^^^^^^^
"were inspired" may be passive voice on line 124 at column 28


In ./.github/PULL_REQUEST_TEMPLATE.md
=============
s one or more issues, or is related to
                         ^^^^^^^^^^
"is related" may be passive voice on line 11 at column 55
-------------
## How Has This Been Tested?
                ^^^^^^^^^^^
"Been Tested" may be passive voice on line 21 at column 16
-------------
request before all these are done, but
                         ^^^^^^^^
"are done" may be passive voice on line 32 at column 51
-------------
     they should be done before getting merged. -->
                 ^^^^^^^
"be done" may be passive voice on line 33 at column 17
-------------
 If the key of a setting is changed, the 'old' attribute is updated or
                         ^^^^^^^^^^
"is changed" may be passive voice on line 35 at column 30
-------------
ged, the 'old' attribute is updated or
                         ^^^^^^^^^^
"is updated" may be passive voice on line 35 at column 62
-------------
      it is resolved in SettingsUpdater.
      ^^^^^
"it is" is wordy or unneeded on line 36 at column 6
-------------
      it is resolved in SettingsUpdater.
         ^^^^^^^^^^^
"is resolved" may be passive voice on line 36 at column 9
-------------
hanges are notable, they are documented in
                         ^^^^^^^^^^^^^^
"are documented" may be passive voice on line 39 at column 41
-------------
## Additional text
   ^^^^^^^^^^
"Additional" is wordy or unneeded on line 42 at column 3
-------------
the translations need to be updated. --->
                         ^^^^^^^^^^
"be updated" may be passive voice on line 45 at column 45


In ./.github/CONTRIBUTING.md
=============
checkconnect is a large project and contributions are more than welcome, so
^^^^^^^^^^^^
"checkconnect" is repeated on line 3 at column 0
-------------
Submit only relevant commits. We don't mind many commits in a pull request,
       ^^^^
"only" can weaken meaning on line 10 at column 7
-------------
t commits. We don't mind many commits in a pull request,
                         ^^^^
"many" is a weasel word and can weaken meaning on line 10 at column 44
-------------
 The pull request should be created from a
                         ^^^^^^^^^^
"be created" may be passive voice on line 13 at column 51
-------------
commits that changes too many
                         ^^^^
"many" can weaken meaning on line 36 at column 68
-------------
  things at the same time are very hard to review. Split large commits into
  ^^^^^^
"things" can weaken meaning on line 37 at column 2
-------------
ngs at the same time are very hard to review. Split large commits into
                         ^^^^
"very" is a weasel word and can weaken meaning on line 37 at column 30
-------------
  passes. Tests can be run using the command
                    ^^^^^^
"be run" may be passive voice on line 42 at column 20
-------------
Especially if you modify something existing, be very clear! Have you
^^^^^^^^^^
"Especially" can weaken meaning on line 55 at column 0
-------------
Especially if you modify something existing, be very clear! Have you
                  ^^^^^^
"modify" is wordy or unneeded on line 55 at column 18
-------------
y something existing, be very clear! Have you
                         ^^^^
"very" is a weasel word and can weaken meaning on line 55 at column 48
-------------
y algorithms, or did you just intend to reorder the code? Justify
                         ^^^^
"just" can weaken meaning on line 56 at column 35
-------------
why the changes are needed.
                ^^^^^^^^^^
"are needed" may be passive voice on line 57 at column 16
-------------
are things we want help with.
    ^^^^^^
"things" can weaken meaning on line 91 at column 4
-------------
git merge --ff-only upstream/dev
               ^^^^
"only" can weaken meaning on line 111 at column 15
-------------
ch and that it's created off of _dev_. Tip: Give it a descriptive
                         ^^^^^^
"off of" is wordy or unneeded on line 119 at column 35
-------------
  'implement-lengthframeencoder-323' or '295-implement-recvbuffer', so that
   ^^^^^^^^^
"implement" is wordy or unneeded on line 121 at column 3
-------------
  others can see what is being worked on.
                         ^^^^^^^^^^^^
"being worked" may be passive voice on line 122 at column 25
-------------
away in your branch it's quite possible that your
                         ^^^^^
"quite" is a weasel word on line 148 at column 46
-------------
upstream _dev_ may be updated. If this happens you should:
                   ^^^^^^^^^^
"be updated" may be passive voice on line 149 at column 19
-------------
git merge --ff-only upstream/dev
               ^^^^
"only" can weaken meaning on line 163 at column 15
-------------
up with several "messy" merges in your history, which we don't want. This
        ^^^^^^^
"several" is a weasel word on line 179 at column 8
-------------
quite often, rather than run the risk of potential merge issues further
^^^^^
"quite" is a weasel word on line 184 at column 0
-------------
just commit to your local branch and push the branch just like you did the
^^^^
"just" can weaken meaning on line 190 at column 0
-------------
anch and push the branch just like you did the
                         ^^^^
"just" can weaken meaning on line 190 at column 53
-------------
ommit will automatically be included in the Pull request.
                         ^^^^^^^^^^^
"be included" may be passive voice on line 191 at column 43
-------------
 can create a new branch off of _develop_ and then cherry pick the
                         ^^^^^^
"off of" is wordy or unneeded on line 215 at column 31


In ./docs/about/EUPL-1.2.md
=============
defined below) which is provided under the terms of this Licence. Any use
                     ^^^^^^^^^^^
"is provided" may be passive voice on line 6 at column 21
-------------
rised under this Licence is prohibited (to
                         ^^^^^^^^^^^^^
"is prohibited" may be passive voice on line 7 at column 57
-------------
the extent such use is covered by a right of the copyright holder of the
                    ^^^^^^^^^^
"is covered" may be passive voice on line 8 at column 20
-------------
Work). The Work is provided under the terms of this Licence when the
                ^^^^^^^^^^^
"is provided" may be passive voice on line 9 at column 16
-------------
ced the following notice immediately
                         ^^^^^^^^^^^
"immediately" can weaken meaning on line 10 at column 60
-------------
s or software that could be created by the
                         ^^^^^^^^^^
"be created" may be passive voice on line 22 at column 54
-------------
  Original Work required in order to classify a work as a Derivative Work;
                         ^^^^^^^^^^^
"in order to" is wordy or unneeded on line 25 at column 25
-------------
  this extent is determined by copyright law applicable in the country
              ^^^^^^^^^^^^^
"is determined" may be passive voice on line 26 at column 14
-------------
 for people to study and modify.
                         ^^^^^^
"modify" is wordy or unneeded on line 30 at column 37
-------------
code which has generally been compiled and
                         ^^^^^^^^^^^^^
"been compiled" may be passive voice on line 31 at column 53
-------------
  which is meant to be interpreted by a computer as a program.
        ^^^^^^^^
"is meant" may be passive voice on line 32 at column 8
-------------
  which is meant to be interpreted by a computer as a program.
                    ^^^^^^^^^^^^^^
"be interpreted" may be passive voice on line 32 at column 20
-------------
nce to do the following, for the duration of copyright
                         ^^^^^^^^^^^^^^^^^^^
"for the duration of" is wordy or unneeded on line 49 at column 43
-------------
- modify the Work, and make Derivative Works based upon the Work,
  ^^^^^^
"modify" is wordy or unneeded on line 54 at column 2
-------------
Those rights can be exercised on any media, supports and formats, whether
                 ^^^^^^^^^^^^
"be exercised" may be passive voice on line 62 at column 17
-------------
he extent allowed by law in order to make
                         ^^^^^^^^^^^
"in order to" is wordy or unneeded on line 65 at column 54
-------------
utable Code. If the Work is provided as Executable Code, the Licensor
                         ^^^^^^^^^^^
"is provided" may be passive voice on line 74 at column 29
-------------
provides in addition a machine-readable copy of the Source Code of the Work
         ^^^^^^^^^^^
"in addition" is wordy or unneeded on line 75 at column 9
-------------
where the Source Code is easily and freely accessible for as
                         ^^^^^^
"easily" can weaken meaning on line 78 at column 38
-------------
Nothing in this Licence is intended to deprive the Licensee of the benefits
                        ^^^^^^^^^^^
"is intended" may be passive voice on line 83 at column 24
-------------
on right:** The Licensee shall keep intact all copyright, patent
                         ^^^^^
"shall" is wordy or unneeded on line 93 at column 36
-------------
tating that the Work has been modified and the date of
                         ^^^^^^^^^^^^^
"been modified" may be passive voice on line 98 at column 44
-------------
will be done under the terms of this Licence or of a later version of this
     ^^^^^^^
"be done" may be passive voice on line 103 at column 5
-------------
is expressly distributed only under this
                         ^^^^
"only" can weaken meaning on line 104 at column 58
-------------
mmunicating ‘EUPL v. 1.2 only’.
                         ^^^^
"only" can weaken meaning on line 105 at column 67
-------------
nnot offer or impose any additional
                         ^^^^^^^^^^
"additional" is wordy or unneeded on line 106 at column 60
-------------
Communication can be done under the terms of this Compatible Licence. For
                  ^^^^^^^
"be done" may be passive voice on line 113 at column 18
-------------
f the Compatible Licence shall prevail.
                         ^^^^^
"shall" is wordy or unneeded on line 117 at column 51
-------------
Code or indicate a repository where this Source will be easily and freely
        ^^^^^^^^
"indicate" is wordy or unneeded on line 121 at column 8
-------------
here this Source will be easily and freely
                         ^^^^^^
"easily" can weaken meaning on line 121 at column 56
-------------
granted hereunder is owned by him/her or licensed to him/her and that
                  ^^^^^^^^
"is owned" may be passive voice on line 133 at column 18
-------------
are owned by him/her or licensed to him/her and that he/she has the power
^^^^^^^^^
"are owned" may be passive voice on line 136 at column 0
-------------
original Licensor and subsequent Contributors grant You a licence to their
                      ^^^^^^^^^^
"subsequent" is wordy or unneeded on line 138 at column 22
-------------
continuously improved by numerous
                         ^^^^^^^^
"numerous" is wordy or unneeded on line 143 at column 66
-------------
Contributors. It is not a finished work and may therefore contain defects
              ^^^^^
"It is" is wordy or unneeded on line 144 at column 14
-------------
 a finished work and may therefore contain defects
                         ^^^^^^^^^
"therefore" is wordy or unneeded on line 144 at column 48
-------------
 ‘bugs’ inherent to this type of development. For the above reason, the
                         ^^^^^^^
"type of" is wordy or unneeded on line 145 at column 27
-------------
Work is provided under the Licence on an ‘as is’ basis and without
     ^^^^^^^^^^^
"is provided" may be passive voice on line 146 at column 5
-------------
warranties of any kind concerning the Work, including without limitation
                       ^^^^^^^^^^
"concerning" is wordy or unneeded on line 147 at column 23
-------------
even if the Licensor has been advised of
                         ^^^^^^^^^^^^
"been advised" may be passive voice on line 161 at column 59
-------------
sibility of such damage. However, the Licensor will be liable under
                         ^^^^^^^
"However" is wordy or unneeded on line 162 at column 32
-------------
## 9.Additional agreements
     ^^^^^^^^^^
"Additional" is wordy or unneeded on line 165 at column 5
-------------
ay choose to conclude an additional
                         ^^^^^^^^^^
"additional" is wordy or unneeded on line 167 at column 59
-------------
However, if accepting obligations, You may act only on your own behalf and
^^^^^^^
"However" is wordy or unneeded on line 169 at column 0
-------------
obligations, You may act only on your own behalf and
                         ^^^^
"only" can weaken meaning on line 169 at column 47
-------------
other Contributor, and only if You agree to indemnify, defend, and hold
                       ^^^^
"only" can weaken meaning on line 171 at column 23
-------------
additional liability.
^^^^^^^^^^
"additional" is wordy or unneeded on line 174 at column 0
-------------
ions of this Licence can be accepted by clicking on an icon ‘I
                         ^^^^^^^^^^^
"be accepted" may be passive voice on line 178 at column 35
-------------
n any other similar way, in accordance
                         ^^^^^^^^^^^^^^^^^^
"in accordance
with" is wordy or unneeded on line 180 at column 58
-------------
ance of this Licence and all of its terms and
                         ^^^^^^
"all of" is wordy or unneeded on line 182 at column 53
-------------
 accept this Licence and all of its
                         ^^^^^^
"all of" is wordy or unneeded on line 183 at column 63
-------------
ommunication of the Work by means of
                         ^^^^^^^^^^^
"by means of" is wordy or unneeded on line 191 at column 57
-------------
ed by the applicable law regarding the Licensor, the Licence and the
                         ^^^^^^^^^
"regarding" is wordy or unneeded on line 195 at column 32
-------------
s granted hereunder will terminate automatically
                         ^^^^^^^^^
"terminate" is wordy or unneeded on line 200 at column 50
-------------
termination will not terminate the licences of any person who has received
                     ^^^^^^^^^
"terminate" is wordy or unneeded on line 202 at column 21
-------------
ment between the Parties as to the Work. If any provision of the
                         ^^^^^
"as to" is wordy or unneeded on line 209 at column 30
-------------
provision will be construed or reformed so as necessary to make it valid
               ^^^^^^^^^^^^
"be construed" may be passive voice on line 212 at column 15
-------------
Appendix, so far this is required and reasonable, without reducing the
                      ^^^^^^^^^^^
"is required" may be passive voice on line 215 at column 22
-------------
will be published with a unique version number. All linguistic versions of
     ^^^^^^^^^^^^
"be published" may be passive voice on line 217 at column 5
-------------
- this Licence shall be governed by the law of the European Union Member
               ^^^^^
"shall" is wordy or unneeded on line 239 at column 15
-------------
- this Licence shall be governed by the law of the European Union Member
                     ^^^^^^^^^^^
"be governed" may be passive voice on line 239 at column 21
-------------
- this licence shall be governed by Belgian law if the Licensor has no
               ^^^^^
"shall" is wordy or unneeded on line 242 at column 15
-------------
- this licence shall be governed by Belgian law if the Licensor has no
                     ^^^^^^^^^^^
"be governed" may be passive voice on line 242 at column 21
-------------
  seat, residence or registered office inside a European Union Member
        ^^^^^^^^^
"residence" is wordy or unneeded on line 243 at column 8


In ./docs/community/contributing.md
=============
Thank you for being interested in contributing to checkconnect. There are
              ^^^^^^^^^^^^^^^^
"being interested" may be passive voice on line 3 at column 14
-------------
many ways you can contribute to the project:
^^^^
"many" is a weasel word and can weaken meaning on line 4 at column 0
-------------
- [Implement new features](https://github.com/jmuelbert/checkconnect/issues?q=is
   ^^^^^^^^^
"Implement" is wordy or unneeded on line 8 at column 3
-------------
- Participate in discussions
  ^^^^^^^^^^^
"Participate" is wordy or unneeded on line 11 at column 2
-------------
Possible bugs may be raised as a "Potential Issue" discussion, feature
                  ^^^^^^^^^
"be raised" may be passive voice on line 20 at column 18
-------------
requests may be raised as an "Ideas" discussion. We can then determine if
             ^^^^^^^^^
"be raised" may be passive voice on line 21 at column 13
-------------
the discussion needs to be escalated into an "Issue" or not, or if we'd
                        ^^^^^^^^^^^^
"be escalated" may be passive voice on line 22 at column 24
-------------
Build and validate the documentation website:
          ^^^^^^^^
"validate" is wordy or unneeded on line 110 at column 10


In ./docs/community/code_of_conduct.md
=============
- Giving and gracefully accepting constructive feedback
             ^^^^^^^^^^
"gracefully" can weaken meaning on line 22 at column 13
-------------
sing on what is best not just for us as individuals, but for the
                         ^^^^
"just" can weaken meaning on line 25 at column 31
-------------
  overall community
  ^^^^^^^
"overall" is wordy or unneeded on line 26 at column 2
-------------
t which could reasonably be considered inappropriate in a
                         ^^^^^^^^^^^^^
"be considered" may be passive voice on line 37 at column 39
-------------
nacceptable behavior may be
                         ^^^^^^^^^^^
"be
reported" may be passive voice on line 62 at column 72
-------------
il]. All complaints will be reviewed and
                         ^^^^^^^^^^^
"be reviewed" may be passive voice on line 64 at column 51
-------------
investigated promptly and fairly.
             ^^^^^^^^
"promptly" can weaken meaning on line 65 at column 13
-------------
nvestigated promptly and fairly.
                         ^^^^^^
"fairly" is a weasel word and can weaken meaning on line 65 at column 26
-------------
All community leaders are obligated to respect the privacy and security of
                      ^^^^^^^^^^^^^
"are obligated" may be passive voice on line 67 at column 22
-------------
te. A public apology may be requested.
                         ^^^^^^^^^^^^
"be requested" may be passive voice on line 83 at column 57
-------------
ing the Code of Conduct, is allowed during
                         ^^^^^^^^^^
"is allowed" may be passive voice on line 105 at column 54
-------------
This Code of Conduct is adapted from the [Contributor Covenant][homepage],
                     ^^^^^^^^^^
"is adapted" may be passive voice on line 120 at column 21
-------------
munity Impact Guidelines were inspired by
                         ^^^^^^^^^^^^^
"were inspired" may be passive voice on line 124 at column 28


In ./docs/guides/install.md
=============
vailable on PyPI and can be installed with
                         ^^^^^^^^^^^^
"be installed" may be passive voice on line 13 at column 42


In ./docs/developer/changelog.md
=============
ges to CheckConnect will be documented in this file.
                         ^^^^^^^^^^^^^
"be documented" may be passive voice on line 5 at column 41
-------------
The format is based on
           ^^^^^^^^
"is based" may be passive voice on line 7 at column 11


In ./docs/index.md
=============
checkconnect is distributed under the terms of the
             ^^^^^^^^^^^^^^
"is distributed" may be passive voice on line 34 at column 13
-------------
AJOR.MINOR' versions can be chosen by using
                         ^^^^^^^^^
"be chosen" may be passive voice on line 39 at column 54
-------------
that have not yet been released.
                  ^^^^^^^^^^^^^
"been released" may be passive voice on line 41 at column 18


In ./README.md
=============
is received within a certain time, it means that the web address or the NTP
^^^^^^^^^^^
"is received" may be passive voice on line 29 at column 0
-------------
vailable. If no response is received or an error occurs, it
                         ^^^^^^^^^^^
"is received" may be passive voice on line 30 at column 36
-------------
tion][documentation-url] is made with
                         ^^^^^^^
"is made" may be passive voice on line 48 at column 39
-------------
mkdocs-material-url] and is hosted by
                         ^^^^^^^^^
"is hosted" may be passive voice on line 49 at column 47
-------------
Many thanks to everyone reporting issues.
^^^^
"Many" is a weasel word and can weaken meaning on line 80 at column 0
-------------
checkconnect is distributed under the terms of the
             ^^^^^^^^^^^^^^
"is distributed" may be passive voice on line 86 at column 13

Copy link

🦙 MegaLinter status: ❌ ERROR

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 24 0 0.29s
✅ COPYPASTE jscpd yes no 1.4s
✅ CSS stylelint 1 1 0 1.51s
✅ HTML djlint 1 0 0.75s
✅ JAVASCRIPT standard 2 1 0 2.12s
✅ JSON jsonlint 2 0 0.28s
✅ JSON prettier 7 4 0 0.78s
✅ JSON v8r 2 0 3.28s
⚠️ MARKDOWN markdownlint 31 0 1 1.61s
❌ MARKDOWN markdown-link-check 31 14 22.78s
✅ MARKDOWN markdown-table-formatter 31 0 0 0.34s
✅ PYTHON mypy 14 0 8.47s
❌ PYTHON pylint 14 8 4.2s
❌ PYTHON pyright 14 28 8.07s
✅ PYTHON ruff 14 0 0 0.09s
✅ REPOSITORY checkov yes no 11.46s
✅ REPOSITORY devskim yes no 1.79s
✅ REPOSITORY dustilock yes no 0.01s
✅ REPOSITORY gitleaks yes no 1.07s
✅ REPOSITORY git_diff yes no 0.03s
✅ REPOSITORY grype yes no 11.97s
✅ REPOSITORY kics yes no 35.2s
✅ REPOSITORY secretlint yes no 0.97s
✅ REPOSITORY syft yes no 0.48s
✅ REPOSITORY trivy yes no 7.56s
✅ REPOSITORY trivy-sbom yes no 6.2s
✅ REPOSITORY trufflehog yes no 5.92s
❌ SPELL cspell 126 2 4.88s
❌ SPELL lychee 99 31 2.28s
✅ YAML prettier 48 0 0 2.35s
❌ YAML v8r 48 1 54.52s
✅ YAML yamllint 48 0 1.25s

See detailed report in MegaLinter reports

You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:

MegaLinter is graciously provided by OX Security

Copy link

This pull request has conflicts with the base branch, please resolve those so we can evaluate the pull request.

Copy link
Owner Author

@jmuelbert jmuelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All OK

Copy link
Owner Author

@jmuelbert jmuelbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alles,OK

Copy link

Conflicts have been resolved! 🎉 A maintainer will review the pull request shortly.

run: pip install --upgrade hatch
- name: 🧰 Install Requirements
run: |
pip install --constraint=.github/workflows/constraints.txt pip

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: pipCommand not pinned by hash
Click Remediation section below to solve this issue
runs-on: ubuntu-latest

steps:
- uses: actions/checkout@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: GitHub-owned GitHubAction not pinned by hash
Click Remediation section below to solve this issue
- uses: actions/checkout@v4

- name: Setup node
uses: actions/setup-node@v4

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: GitHub-owned GitHubAction not pinned by hash
Click Remediation section below to solve this issue
run: npm test

- name: Upload Jest Test Results
uses: trunk-io/analytics-uploader@main

Check warning

Code scanning / Scorecard

Pinned-Dependencies Medium

score is 6: third-party GitHubAction not pinned by hash
Click Remediation section below to solve this issue

# - name: Run pre-commit with hatch
# run: hatch run check:pre-commit run --all-files
# TODO: remove pre-commit

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

1 similar comment
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@@ -124,7 +126,8 @@

def main() -> int: # no cov
"""Entry point for the module."""
return checkconnect(sys.argv[1:])
checkconnect(sys.argv[1:])

Check warning

Code scanning / Prospector (reported by Codacy)

No value for argument 'url_data' in function call (no-value-for-parameter) Warning

No value for argument 'url_data' in function call (no-value-for-parameter)
@@ -124,7 +126,8 @@

def main() -> int: # no cov
"""Entry point for the module."""
return checkconnect(sys.argv[1:])
checkconnect(sys.argv[1:])

Check warning

Code scanning / Prospector (reported by Codacy)

No value for argument 'pdf_output' in function call (no-value-for-parameter) Warning

No value for argument 'pdf_output' in function call (no-value-for-parameter)
@@ -17,5 +13,5 @@
__version_tuple__: VERSION_TUPLE
version_tuple: VERSION_TUPLE

__version__ = version = "0.0.1.dev69"
__version_tuple__ = version_tuple = (0, 0, 1, "dev69")
__version__ = version = "0.1.0.dev183"

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

Constant name "version" doesn't conform to UPPER_CASE naming style Warning

Constant name "version" doesn't conform to UPPER_CASE naming style
@@ -124,7 +126,8 @@

def main() -> int: # no cov
"""Entry point for the module."""
return checkconnect(sys.argv[1:])
checkconnect(sys.argv[1:])

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

No value for argument 'url_data' in function call Warning

No value for argument 'url_data' in function call
@@ -124,7 +126,8 @@

def main() -> int: # no cov
"""Entry point for the module."""
return checkconnect(sys.argv[1:])
checkconnect(sys.argv[1:])

Check warning

Code scanning / Pylintpython3 (reported by Codacy)

No value for argument 'pdf_output' in function call Warning

No value for argument 'pdf_output' in function call
run: npm test

- name: Upload Jest Test Results
uses: trunk-io/analytics-uploader@main

Check warning

Code scanning / Semgrep (reported by Codacy)

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Warning

An action sourced from a third-party repository on GitHub is not pinned to a full length commit SHA. Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release.
@@ -2,7 +2,7 @@
padding-left: 20px;
margin-bottom: 30px;
border-left: 5px solid;
border-left-color: rgb(230, 230, 230);
border-left-color: rgb(230 230 230);

Check notice

Code scanning / Csslint (reported by Codacy)

Expected () but found 'rgb(230 230 230)'. Note documentation

Expected () but found 'rgb(230 230 230)'.
@@ -17,5 +13,5 @@
__version_tuple__: VERSION_TUPLE
version_tuple: VERSION_TUPLE

__version__ = version = "0.0.1.dev69"
__version_tuple__ = version_tuple = (0, 0, 1, "dev69")
__version__ = version = "0.1.0.dev183"

Check warning

Code scanning / Pylint (reported by Codacy)

Constant name "version" doesn't conform to UPPER_CASE naming style Warning

Constant name "version" doesn't conform to UPPER_CASE naming style
__version__ = version = "0.0.1.dev69"
__version_tuple__ = version_tuple = (0, 0, 1, "dev69")
__version__ = version = "0.1.0.dev183"
__version_tuple__ = version_tuple = (0, 1, 0, "dev183")

Check warning

Code scanning / Pylint (reported by Codacy)

Constant name "version_tuple" doesn't conform to UPPER_CASE naming style Warning

Constant name "version_tuple" doesn't conform to UPPER_CASE naming style
@@ -124,7 +126,8 @@

def main() -> int: # no cov
"""Entry point for the module."""
return checkconnect(sys.argv[1:])
checkconnect(sys.argv[1:])

Check warning

Code scanning / Pylint (reported by Codacy)

No value for argument 'url_data' in function call Warning

No value for argument 'url_data' in function call
@@ -124,7 +126,8 @@

def main() -> int: # no cov
"""Entry point for the module."""
return checkconnect(sys.argv[1:])
checkconnect(sys.argv[1:])

Check warning

Code scanning / Pylint (reported by Codacy)

No value for argument 'pdf_output' in function call Warning

No value for argument 'pdf_output' in function call
@@ -40,7 +40,9 @@
"""
assert self.settings.get("app_name") == "app-name"

def test_get_default_value_when_setting_not_found_with_success(self) -> None:
def test_get_default_value_when_setting_not_found_with_success(
self,

Check warning

Code scanning / Pylint (reported by Codacy)

Wrong hanging indentation before block (add 4 spaces). Warning test

Wrong hanging indentation before block (add 4 spaces).
| | |
| CI/CD | [![CI - Build CheckConnect][ci-cd-badge]][ci-cd-wf-url] |
| Documentation | [![docs][docs-badge]][docs-wf-url] |
| Package | [![PyPI - Version][pypi-version-badge]][pypi-version-url] \[!\[PyPI - Downloads\] [pypi-downloads-badge]\][pypi-downloads-URL] [![PyPI - Python Version][python-version-badge]][python-version-url] |

Check warning

Code scanning / Remark-lint (reported by Codacy)

Warn when shortcut reference links are used. Warning

[no-shortcut-reference-link] Use the trailing [] on reference links
| Documentation | [![docs][docs-badge]][docs-wf-url] |
| Package | [![PyPI - Version][pypi-version-badge]][pypi-version-url] \[!\[PyPI - Downloads\] [pypi-downloads-badge]\][pypi-downloads-URL] [![PyPI - Python Version][python-version-badge]][python-version-url] |
| Meta | [![linting - Ruff][ruff-badge]][ruff-url] [![types - Mypy][mypy-badge]][mypy-url] [![GitHub license][github_license_badge]][license] |
| Dependencies | \[!\[Dependabot auto-merge\] [dependabot_merge_action_badge]\][depandabot_merge_action] \[!\[Dependency Review\] [dependency_review_action_badge]\][dependency_review_action] |

Check warning

Code scanning / Remark-lint (reported by Codacy)

Warn when shortcut reference links are used. Warning

[no-shortcut-reference-link] Use the trailing [] on reference links
1. Fork the repository and create a new branch
1. Make your changes
1. Check for existing related issues.
1. Fork the repository and create a new branch.

Check warning

Code scanning / Remark-lint (reported by Codacy)

Warn when the list item marker values of ordered lists violate a given Warning documentation

[ordered-list-marker-value] Marker should be 2, was 1
1. Make your changes
1. Check for existing related issues.
1. Fork the repository and create a new branch.
1. Make your changes.

Check warning

Code scanning / Remark-lint (reported by Codacy)

Warn when the list item marker values of ordered lists violate a given Warning documentation

[ordered-list-marker-value] Marker should be 3, was 1
"eslint.experimental.useFlatConfig": true,
"eslint.options": {
"overrideConfigFile": "./.config/eslint.config.js",
},

Check warning

Code scanning / Jacksonlinter (reported by Codacy)

Unexpected character ('}' (code 125)): was expecting double-quote to start field name Warning

Unexpected character ('}' (code 125)): was expecting double-quote to start field name
"group": {
"kind": "test",
"isDefault": true,
},

Check warning

Code scanning / Jacksonlinter (reported by Codacy)

Unexpected character ('}' (code 125)): was expecting double-quote to start field name Warning

Unexpected character ('}' (code 125)): was expecting double-quote to start field name
| Package | [![PyPI - Version][pypi-version-badge]][pypi-version-url] [![PyPI - Downloads] [pypi-downloads-badge]][pypi-downloads-url] [![PyPI - Python Version][python-version-badge]][python-version-url] |
| Meta | [![linting - Ruff][ruff-badge]][ruff-url] [![types - Mypy][mypy-badge]][mypy-url] [![GitHub license][github_license_badge]][license] |
| Dependencies | [![Dependabot auto-merge] [dependabot_merge_action_badge]][depandabot_merge_action] [![Dependency Review] [dependency_review_action_badge]][dependency_review_action] |
| | |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 215 Warning

Expected: 80; Actual: 215
| Dependencies | [![Dependabot auto-merge] [dependabot_merge_action_badge]][depandabot_merge_action] [![Dependency Review] [dependency_review_action_badge]][dependency_review_action] |
| | |
|---------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| | |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 215 Warning

Expected: 80; Actual: 215
| | |
|---------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| | |
| CI/CD | [![CI - Build CheckConnect][ci-cd-badge]][ci-cd-wf-url] |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 215 Warning

Expected: 80; Actual: 215
|---------------|-----------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------|
| | |
| CI/CD | [![CI - Build CheckConnect][ci-cd-badge]][ci-cd-wf-url] |
| Documentation | [![docs][docs-badge]][docs-wf-url] |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 215 Warning

Expected: 80; Actual: 215
| | |
| CI/CD | [![CI - Build CheckConnect][ci-cd-badge]][ci-cd-wf-url] |
| Documentation | [![docs][docs-badge]][docs-wf-url] |
| Package | [![PyPI - Version][pypi-version-badge]][pypi-version-url] \[!\[PyPI - Downloads\] [pypi-downloads-badge]\][pypi-downloads-URL] [![PyPI - Python Version][python-version-badge]][python-version-url] |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 215 Warning

Expected: 80; Actual: 215
| CI/CD | [![CI - Build CheckConnect][ci-cd-badge]][ci-cd-wf-url] |
| Documentation | [![docs][docs-badge]][docs-wf-url] |
| Package | [![PyPI - Version][pypi-version-badge]][pypi-version-url] \[!\[PyPI - Downloads\] [pypi-downloads-badge]\][pypi-downloads-URL] [![PyPI - Python Version][python-version-badge]][python-version-url] |
| Meta | [![linting - Ruff][ruff-badge]][ruff-url] [![types - Mypy][mypy-badge]][mypy-url] [![GitHub license][github_license_badge]][license] |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 215 Warning

Expected: 80; Actual: 215
| Documentation | [![docs][docs-badge]][docs-wf-url] |
| Package | [![PyPI - Version][pypi-version-badge]][pypi-version-url] \[!\[PyPI - Downloads\] [pypi-downloads-badge]\][pypi-downloads-URL] [![PyPI - Python Version][python-version-badge]][python-version-url] |
| Meta | [![linting - Ruff][ruff-badge]][ruff-url] [![types - Mypy][mypy-badge]][mypy-url] [![GitHub license][github_license_badge]][license] |
| Dependencies | \[!\[Dependabot auto-merge\] [dependabot_merge_action_badge]\][depandabot_merge_action] \[!\[Dependency Review\] [dependency_review_action_badge]\][dependency_review_action] |

Check warning

Code scanning / Markdownlint (reported by Codacy)

Expected: 80; Actual: 215 Warning

Expected: 80; Actual: 215
notice immediately following the copyright notice for the Work:
Licensed under the EUPL
or has expressed by any other means his willingness to license under the EUPL.
_EUPL © the European Union 2007, 2016_

Check warning

Code scanning / Markdownlint (reported by Codacy)

Emphasis used instead of a heading Warning documentation library

Emphasis used instead of a heading
@jmuelbert jmuelbert merged commit da39671 into main Jan 28, 2025
33 of 44 checks passed
@jmuelbert jmuelbert deleted the feature/test-build-workflow branch January 28, 2025 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant