Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Added icon on external links #184

Merged
merged 1 commit into from
Jan 30, 2025

Conversation

applejag
Copy link
Contributor

@applejag applejag commented Jan 29, 2025

I was browsing the docs and got confused by some links sending me to wikipedia thought "hmm I wish the docs had that icon thing to show which links are external links". A quick google showed that vitepress has this built in.

Before:

image

After:

image


It would be much nicer to have something like the favicon to the page next to the link, you know like this:

image

(https://css-tricks.com/favicons-next-to-external-links/)

but I couldn't find a quick solution for that with vitepress online and didn't have the energy to dig much further so I just settled for the built in feature.

Copy link

codecov bot commented Jan 29, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.92%. Comparing base (3ad3902) to head (831508f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #184   +/-   ##
=======================================
  Coverage   95.92%   95.92%           
=======================================
  Files          49       49           
  Lines        3144     3144           
=======================================
  Hits         3016     3016           
  Misses        101      101           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@jmattheis jmattheis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, the builtin feature is good enough.

@jmattheis jmattheis merged commit e65ffbf into jmattheis:main Jan 30, 2025
7 checks passed
@applejag applejag deleted the docs/external-link-icon branch January 31, 2025 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants