Make all shutdown and force_flush methods async

jjatria · Nov 23, 2023 · f03af81 · f03af81
1 parent 170809b
commit f03af81
Show file tree

Hide file tree

Showing 5 changed files with 9 additions and 2 deletions.
diff --git a/Changes b/Changes
@@ -4,6 +4,8 @@ Revision history for OpenTelemetry-Exporter-OTLP
 
     * Bump Object::Pad dependency to 0.74 to ensure
       support for field initialisers
+    * Make all shutdown and force_flush methods async.
+      This adds a new dependency on Future::AsyncAwait
 
 0.013     2023-11-21 23:19:28+00:00 Europe/London
 

diff --git a/META.json b/META.json
@@ -48,6 +48,7 @@
          "requires" : {
             "Feature::Compat::Try" : "0",
             "File::Share" : "0",
+            "Future::AsyncAwait" : "0.38",
             "HTTP::Tiny" : "0",
             "JSON::MaybeXS" : "0",
             "Metrics::Any" : "0",

diff --git a/Makefile.PL b/Makefile.PL
@@ -26,6 +26,7 @@ my %WriteMakefileArgs = (
   "PREREQ_PM" => {
     "Feature::Compat::Try" => 0,
     "File::Share" => 0,
+    "Future::AsyncAwait" => "0.38",
     "HTTP::Tiny" => 0,
     "JSON::MaybeXS" => 0,
     "Metrics::Any" => 0,
@@ -54,6 +55,7 @@ my %FallbackPrereqs = (
   "Feature::Compat::Try" => 0,
   "File::Share" => 0,
   "File::Spec" => 0,
+  "Future::AsyncAwait" => "0.38",
   "HTTP::Tiny" => 0,
   "JSON::MaybeXS" => 0,
   "Metrics::Any" => 0,

diff --git a/cpanfile b/cpanfile
@@ -1,4 +1,5 @@
 requires 'Feature::Compat::Try';
+requires 'Future::AsyncAwait', '0.38'; # Object::Pad compatibility
 requires 'File::Share';
 requires 'HTTP::Tiny';
 requires 'JSON::MaybeXS';

diff --git a/lib/OpenTelemetry/Exporter/OTLP.pm b/lib/OpenTelemetry/Exporter/OTLP.pm
@@ -7,6 +7,7 @@ our $VERSION = '0.014';
 
 class OpenTelemetry::Exporter::OTLP :does(OpenTelemetry::Exporter) {
     use Feature::Compat::Try;
+    use Future::AsyncAwait;
     use HTTP::Tiny;
     use Module::Runtime 'require_module';
     use OpenTelemetry::Common qw( config maybe_timeout timeout_timestamp );
@@ -307,12 +308,12 @@ class OpenTelemetry::Exporter::OTLP :does(OpenTelemetry::Exporter) {
         $self->$send_request( $request, $timeout );
     }
 
-    method shutdown ( $timeout = undef ) {
+    async method shutdown ( $timeout = undef ) {
         $stopped = 1;
         TRACE_EXPORT_SUCCESS;
     }
 
-    method force_flush ( $timeout = undef ) {
+    async method force_flush ( $timeout = undef ) {
         TRACE_EXPORT_SUCCESS;
     }
 }