-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add new logo as favicon #5501
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We can test this out. It will only affect the prerelease
site.
To affect everything, we could try putting it as favicon.png
in https://github.com/jj-vcs/jj-vcs.github.io. (We might have to experiment, I'm not sure whether it needs to be ICO or can be PNG). The comment about the size applies to that too.
bb88598
to
c12f561
Compare
I’ll get you a bigger PNG and SVG tomorrow, the file sent over Discord will probably be artifacty. I just need to make sure there’s no gross metadata in the files before I put them on the internet. I think this is the favicon generator I’ve used in the past, I recall there being weird platform quirks about getting the high quality versions to show up everywhere. This may be overkill for the docs site though. |
c12f561
to
5859317
Compare
I don't trust Discord so I pushed a full size image here to a branch. The SVG that Canva exports isn't really vector art, it just has the base64-encoded PNG inside it. |
5859317
to
bcc8d43
Compare
Thanks! I uploaded that image to the favicon generator you linked to. I added the same background color as we use elsewhere. Then I took the generated |
I think ico is deprecated for favicons, it’s there as a last resort. All modern browsers will use the higher quality PNG versions if the link tags exist for it. Let me give it a try soon and post a suggested here? I suppose it would be find to merge as is and improve it later. |
Thanks. I'll wait. |
bcc8d43
to
96bf85f
Compare
Done |
Checklist
If applicable:
CHANGELOG.md