Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github: migrate to GHA aarch64 runners #5460

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Conversation

thoughtpolice
Copy link
Member

We no longer need to do cross compilation, and these instances seem pretty fast. Enable them everywhere across the board.

Checklist

If applicable:

  • I have updated CHANGELOG.md
  • I have updated the documentation (README.md, docs/, demos/)
  • I have updated the config schema (cli/src/config-schema.json)
  • I have added tests to cover my changes

@emilazy
Copy link
Contributor

emilazy commented Jan 25, 2025

Perhaps should move all the Macs to AArch64 too? Should be just as easy to build binaries for x86, and the AArch64 runners have Rosetta 2 and thus can handle the tests too; and of course the speed improvement should be even larger.

@thoughtpolice
Copy link
Member Author

How do we cross compile on macOS? We don't even need cross, right? The main reason I haven't done it is just bc I haven't swapped over to my Mac in a while to debug issues.

@emilazy
Copy link
Contributor

emilazy commented Jan 25, 2025

It can just be used as a native x86 Darwin machine – could even install a native x86 Rust toolchain. I’d assume cargo --target and so on also just works, though (and would be faster).

@thoughtpolice
Copy link
Member Author

Alright, I'll try that, but I'll do a follow up for it in a separate PR since I might have to hit it with a wrench a few times. I think this is good to go, though.

We no longer need to do cross compilation, and these instances seem
pretty fast. Enable them everywhere across the board.

Signed-off-by: Austin Seipp <[email protected]>
@thoughtpolice thoughtpolice force-pushed the aseipp/push-psqvkumsplzy branch from d01c4f1 to 8144ffc Compare February 6, 2025 14:30
@thoughtpolice thoughtpolice added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 8144ffc Feb 6, 2025
60 checks passed
@thoughtpolice thoughtpolice deleted the aseipp/push-psqvkumsplzy branch February 6, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants