fix(remote-control) Move robotjs import #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damencho
approved these changes
Apr 19, 2023
|
Unfortunate that this performance optimization is no longer working. Background for this was #214, which is still a recommended practice from the electron docs: https://www.electronjs.org/docs/latest/tutorial/performance#2-loading-and-running-code-too-soon |
|
Yep they changed something starting electron 23.0.0 and we would get the mentioned error unfortunately. |
|
The upstream issue is electron/electron#37404, this is affecting other modules apart from robotjs as well |
|
@horymury and just a fyi, Wayland screensharing was also completely broken (as in segfault every time when trying) with electron 22 or later, see jitsi/jitsi-meet-electron#829 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is in order to avoid
on Electron apps using electron v23.0.0 and newer