Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event_sync, feat: add number of active occupants to join/left events #35

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

iamtakingiteasy
Copy link
Contributor

Active occupants are already tracked in implementation; this adds the tally to join/left events, allowing to avoid similar tracking on the API consumer side.

@iamtakingiteasy iamtakingiteasy changed the title event_sync, feat: include number of active occupants to join/left events event_sync, feat: add number of active occupants to join/left events Oct 19, 2024
Copy link
Collaborator

@shawnchin shawnchin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for your contribution!

PR looks good. Just a couple of minor ambiguities to address.

Pardon my pedantry 🙇🏽

event_sync/mod_event_sync_component.lua Outdated Show resolved Hide resolved
event_sync/mod_event_sync_component.lua Outdated Show resolved Hide resolved
event_sync/README.md Outdated Show resolved Hide resolved
event_sync/README.md Outdated Show resolved Hide resolved
@shawnchin shawnchin merged commit ecfdcdc into jitsi-contrib:main Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants