proxybased_external_services: module to enable dynamic redirects to services based on an http header #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @shawnchin, do you have time to review this PR? |
|
@emrahcom I'm afraid I don't currently have the bandwidth to review. Happy to merge. |
|
@fluxxcode thanks for your contribution! Can you take a look at the luacheck issues please? |
|
@shawnchin The luacheck issues should be resolved now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the new
proxybased_external_servicesmodule, which extends Jitsi's originalexternal_servicesmodule to allow redirection of different clients to different services based on an HTTP header in the requests.This is useful, for example, if internal clients should use different turn servers than external clients.