Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add protoc-gen-ts #113

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

docs: add protoc-gen-ts #113

wants to merge 1 commit into from

Conversation

thesayyn
Copy link

@thesayyn thesayyn commented Feb 17, 2022

Copy link
Owner

@jin jin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a nit.

@@ -627,6 +627,9 @@ Have something to contribute or discuss? [Open a pull request](https://github.co
<ul>
<li><a href="https://github.com/bazelbuild/rules_proto">bazelbuild/rules_proto</a>: Starlark implementation of the Protobuf rules in Bazel</li>
</ul>
<ul>
<li><a href="https://github.com/thesayyn/protoc-gen-ts">thesayyn/protoc-gen-ts</a>TypeScript generator with first-class bazel rules.</li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<li><a href="https://github.com/thesayyn/protoc-gen-ts">thesayyn/protoc-gen-ts</a>TypeScript generator with first-class bazel rules.</li>
<li><a href="https://github.com/thesayyn/protoc-gen-ts">thesayyn/protoc-gen-ts</a>: TypeScript generator with first-class bazel rules.</li>

@@ -627,6 +627,9 @@ Have something to contribute or discuss? [Open a pull request](https://github.co
<ul>
<li><a href="https://github.com/bazelbuild/rules_proto">bazelbuild/rules_proto</a>: Starlark implementation of the Protobuf rules in Bazel</li>
</ul>
<ul>
<li><a href="https://github.com/thesayyn/protoc-gen-ts">thesayyn/protoc-gen-ts</a>TypeScript generator with first-class bazel rules.</li>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should go into the TypeScript section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add protoc-gen-ts to proto rules.
2 participants