Allow arrays inside nested parameters #226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When one scope is handled by multiple fields, we need to add each of those fields to the permitted params. However, when one of those inner fields includes multiple-select fields, we don't instruct Strong Parameters that those params expect arrays. As a result, those keys are dropped. This commit fixes that, recursively handling each nested param, so that arrays and other nested fields are supported.
neilvcarvalho
force-pushed
the
nc-multiple-fields-multi-select
branch
from
ac15fd6 to
d47f5d9
Compare
|
Closing in favor of #213 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one scope is handled by multiple fields, we need to add each of those fields to the permitted params. However, when one of those inner fields includes multiple-select fields, we don't instruct Strong Parameters that those params expect arrays. As a result, those keys are dropped.
This commit fixes that, recursively handling each nested param, so that arrays and other nested fields are supported.
Fixes #225