Version 0.9.20

- Now validating timezone on create_event, update_event, run_event and update_job APIs
- Fixes #571

lib/api.js

@@ -5,6 +5,7 @@
 var fs = require('fs');
 var assert = require("assert");
 var async = require('async');
+var moment = require('moment-timezone');
 
 var Class = require("pixl-class");
 var Tools = require("pixl-tools");
@@ -259,6 +260,15 @@ module.exports = Class.create({
 			}
 		} // timing
 
+		// timezone must be one of the supported moment timezones
+		if (event.timezone) {
+			var zones = moment.tz.names();
+			if (!zones.includes(event.timezone)) {
+				this.doError('api', "Malformed or unknown timezone: " + event.timezone, callback);
+				return false;
+			}
+		}
+
 		return true;
 	},
 

lib/test.js

@@ -795,6 +795,34 @@ module.exports = {
 			} );
 		},
 
+		function testAPIUpdateEventBadTimezone(test) {
+			// test app/update_event api with a bad tz (should error out)
+			var self = this;
+			var params = {
+				"id": this.event_id,
+				"timezone": "THIS IS BAD",
+				"session_id": session_id
+			};
+
+			request.json( api_url + '/app/update_event', params, function(err, resp, data) {
+
+				test.ok( !err, "No error requesting API" );
+				test.ok( "code" in data, "Found code prop in JSON response" );
+				test.ok( data.code == 'api', "Code is api" );
+
+				// make sure event didn't get saved in storage
+				storage.listFind( 'global/schedule', { id: self.event_id }, function(err, event) {
+					test.ok( !err, "No error fetching data" );
+					test.ok( !!event, "Data record record is non-null" );
+					test.ok( event.username == "admin", "Username is correct" );
+					test.ok( event.created > 0, "Record creation date is non-zero" );
+					test.ok( event.timezone == cronicle.tz, "New timezone is correct (not changed)" );
+
+					test.done();
+				} );
+			} );
+		},
+
 		// app/get_schedule
 
 		function testAPIGetSchedule(test) {

package.json

@@ -1,6 +1,6 @@
 {
 	"name": "Cronicle",
-	"version": "0.9.19",
+	"version": "0.9.20",
 	"description": "A simple, distributed task scheduler and runner with a web based UI.",
 	"author": "Joseph Huckaby <[email protected]>",
 	"homepage": "https://github.com/jhuckaby/Cronicle",