Salt upgrade

[dxenes1]

This PR is ready for review.

Changes:

• Updates salt bootstrap to support latest Salt LTS
• Directly specifies system python for all pip installs. WARNING: This is probably the last python version we can do this with, as system installs are not recommended and usually are blocked from python 3.12 onwards.
• Removes editable install for heaviside
• Upgrades base AMI to ubuntu 22.04 (python 3.10)
• Installs uwsgi via apt-get instead of pip due to issues with setuptools

[sandyhider]

I am wondering if we should be using 3006. This is what ChatGPT says about versions:

SaltStack adheres to a [CalVer](https://calver.org/) versioning scheme, where:

Versions are formatted as YYYY.MM (e.g., 3006 corresponds to a release in 2023, June).
Odd-numbered versions (e.g., 3007) are feature releases, introducing new functionality.
Even-numbered versions (e.g., 3006) are LTS (Long-Term Support) releases, focusing on stability and bug fixes.
Key Differences
Purpose of Releases:

Odd Versions (Feature Releases):
Introduce new features and enhancements.
Serve as a preview for the next stable LTS release.
May include experimental features or breaking changes.
Typically have shorter support lifespans.
Even Versions (LTS Releases):
Focus on stability, reliability, and performance.
Incorporate features introduced in the previous odd release, but fully tested and refined.
Receive long-term updates for security and critical bug fixes.
Stability:

LTS versions (even) are better suited for production environments where stability is critical.
Feature releases (odd) are more appropriate for development, testing, or environments where early adoption of new features is desired.
Support Lifecycle:

Odd-numbered versions have a shorter support window, typically ending shortly after the release of the next LTS version.
Even-numbered (LTS) versions are supported for an extended period, ensuring long-term stability for enterprise deployments.```

What do you think?

[sandyhider]

What takes it Python 3.11 I wasn't sure from the review?

[dxenes1]

It's the ubuntu version,
20.04 comes with python 3.8
22.04 comes with python 3.10
24.04 comes with python 3.12

22.04 works best because python 3.12 doesn't allow system pip installs

[movestill]

These v3.5 requirements aren't causing problems?

[dxenes1]

Ah I missed that require, looks like the pyminifier salt file is only used in the "workstation" packer AMI though so it might not be executed when creating the core AMIs for the stack...Not sure what "workstation" is for? A developer environment I'm guessing?

    'workstation*':
        - python.python35
        - git
        - vault.client
        - aws.boto3
        - python.pyminifier

[movestill]

Yeah I think `workstation` was a dev EC2. There are a few other instances of v3.5 in some of the Salt files besides this one.

…

On Mon, Dec 9, 2024 at 10:37 AM Daniel Xenes ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In salt_stack/salt/python/pyminifier.sls <#129 (comment)> : > @@ -6,7 +6,7 @@ include: pyminifier: pip.installed: - name: pyminifier==2.1 - - bin_env: /usr/local/bin/pip3 + - pip_bin: /usr/bin/pip3 - require: - sls: python.python35 Ah I missed that require, looks like the pyminifier salt file is only used in the "workstation" packer AMI though so it might not be executed when creating the core AMIs for the stack...Not sure what "workstation" is for? A developer environment I'm guessing? 'workstation*': - python.python35 - git - vault.client - aws.boto3 - python.pyminifier — Reply to this email directly, view it on GitHub <#129 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ABYVSA46L7O3KGVEMLIJ3GD2EW2KFAVCNFSM6AAAAABSHXK4I2VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDIOBZGE4TIOBTGA> . You are receiving this because your review was requested.Message ID: ***@***.***>