Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename variables #11780

Merged
merged 3 commits into from
Jan 25, 2025
Merged

Rename variables #11780

merged 3 commits into from
Jan 25, 2025

Conversation

qmonmert
Copy link
Contributor

No description provided.

@murdos
Copy link
Contributor

murdos commented Jan 25, 2025

I'm not really convinced new names are better. Current names are fine for me.

@qmonmert
Copy link
Contributor Author

@murdos thank you for your review, so if you are not convinced there are a lot of variables to rename:




"baseName": "APP_NAME",

...

@pascalgrimaud
Copy link
Member

not a big deal, and like this, it can be consistent, so let's merge it

@pascalgrimaud pascalgrimaud merged commit 47eec22 into jhipster:main Jan 25, 2025
38 checks passed
@qmonmert qmonmert mentioned this pull request Jan 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants