Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removes filtering question from entity #210

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Removes filtering question from entity #210

merged 1 commit into from
Nov 25, 2020

Conversation

JasonTypesCodes
Copy link
Contributor

@atomfrede I think we should reconsider just removing this question for the time being until support is ready from #193

@murdos What are your thoughts?

@murdos
Copy link
Contributor

murdos commented Nov 24, 2020

Yeah, go for it.
Unfortunately #193 is not ready. It was working with micronaut-data 2.0.1 but unfortunately version 2.1.0 broke something related to Spring transaction management, and now we have CannotCreateTransaction errors. It might be related to micronaut-projects/micronaut-data#775 but I had no time to investigate further.

atomfrede
atomfrede approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@atomfrede atomfrede left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes let's remove it for now.

@atomfrede atomfrede merged commit 378acb6 into main Nov 25, 2020
@JasonTypesCodes JasonTypesCodes deleted the remove-filtering-question branch April 10, 2021 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@atomfrede atomfrede atomfrede approved these changes

@murdos murdos murdos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JasonTypesCodes @murdos @atomfrede