Skip to content

Commit

Permalink
chore!: remove deprecated Error.String method (#354)
Browse files Browse the repository at this point in the history
Signed-off-by: James Hillyerd <[email protected]>
  • Loading branch information
jhillyerd authored Sep 7, 2024
1 parent 10d32da commit b64fcd6
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
5 changes: 0 additions & 5 deletions error.go
Original file line number Diff line number Diff line change
Expand Up @@ -43,11 +43,6 @@ func (e *Error) Error() string {
return fmt.Sprintf("[%s] %s: %s", sev, e.Name, e.Detail)
}

// String formats the enmime.Error as a string. DEPRECATED; use Error() instead.
func (e *Error) String() string {
return e.Error()
}

// addError builds a severe Error and appends to the Part error slice.
func (p *Part) addError(name string, detail string) {
p.addProblem(&Error{name, detail, true})
Expand Down
3 changes: 1 addition & 2 deletions error_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -27,9 +27,8 @@ func TestErrorStringConversion(t *testing.T) {
Severe: true,
}

// Using deprecated String() method here for test coverage
want = "[E] ErrorName: Error Details"
got = e.String()
got = e.Error()
if got != want {
t.Error("got:", got, "want:", want)
}
Expand Down

0 comments on commit b64fcd6

Please sign in to comment.