Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing Inline and Block AST elements #102

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

rnwst
Copy link

@rnwst rnwst commented Oct 1, 2022

Constructors for Inline and Block elements were missing the LineBlock and Underline elements. The constructors now match with the elements listed at
https://hackage.haskell.org/package/pandoc-types-1.22.2.1/docs/Text-Pandoc-Definition.html.

Constructors for Inline and Block elements were missing the LineBlock
and Underline elements. The constructors now match with the elements
listed at
https://hackage.haskell.org/package/pandoc-types-1.22.2.1/docs/Text-Pandoc-Definition.html.
@jgm
Copy link
Owner

jgm commented Oct 1, 2022

Not sure why CI is failing. We can try rerunning later.

@ickc
Copy link
Collaborator

ickc commented Oct 3, 2022

The CI has been acting up to me lately.

I am quite busy at the moment so I am sorry I won't have time to look at it soon. I'll come back to this later.

@sergiocorreia
Copy link
Contributor

The CI has been acting up to me lately.

I am quite busy at the moment so I am sorry I won't have time to look at it soon. I'll come back to this later.

Possibly related, but I had to tweak the panflute CI code due to a change in how github.com distributes the assets (particularly, pandoc): sergiocorreia/panflute@b1fcddfa

@ickc
Copy link
Collaborator

ickc commented Oct 3, 2022

Very likely to be this, it starts acting up around 2 weeks ago.

When I first set up the logic like that, it is pre-github actions era. When I have the time I'd refactor it into a GitHub Action perhaps and so that we can fix any future problems in one single place.

@ickc
Copy link
Collaborator

ickc commented Oct 3, 2022

Actually someone already did that: https://github.com/marketplace/actions/setup-pandoc

I'll try to use it in other repositories first and if it works well propagate here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants