Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

website-navbar changing issue solved #766

Closed
wants to merge 3 commits into from
Closed

website-navbar changing issue solved #766

wants to merge 3 commits into from

Conversation

Yashgabani845
Copy link
Contributor

IMPORTANT: When creating your Pull Request, please use the following format for the title: Category - Resource Name & Section

Closes #672

Description:

i have chnaged mainly css of the about page
and made same as ther home page

Request :

i want to request you about one thing
i saw that css of home page is getting bad after many PRs
someone has remvoed dark mode button and someone has removed toggle button
so please look at the file changes people are chnaging style of other things for their feature

Checklist:

Before submitting your pull request, ensure that you have completed the following tasks:

  • I have carefully reviewed and adhered to the contributing guidelines before creating this pull request.
  • I followed the prescribed PR title template. (Check this if you're adding a resource)

fill the bracket with x. Something like this [x]

Copy link

github-actions bot commented Jun 3, 2024

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@Yashgabani845
Copy link
Contributor Author

bandicam.2024-06-03.12-41-31-644.mp4

@jfmartinz just look at this video this is current situation of white theme
and the worst part is there is no button of chnaging dark to white or white to dark in home page
it showing to user according to browser chrome shwoing me dark mode and firefox white one
the main issue is everyone has thier own css of thier forked repo for white mode and people edit according to their view but at the end after merge overall look is getting like this
so i would request you to please look over it and assign white theme css to one person not multiple,
i will be too happy to work on that
if you agreed then please tell me i will raise issue on this

@Yashgabani845
Copy link
Contributor Author

@jfmartinz condition of dark theme is very good
but because of multiple persons working on white theme so ...

@jfmartinz
Copy link
Owner

Can I see your work? I am trying to enabled the preview in production, so I will see the output easily. Also we're trying to make some unit testing to make sure everything works even after changes of other perople.

@Yashgabani845
Copy link
Contributor Author

Screenshot (355)
Screenshot (356)
sorry for uplaoding late but these are relevant ss for current issue

@Yashgabani845
Copy link
Contributor Author

@jfmartinz please checkout the screenshots of both pages as made both identical

@jfmartinz
Copy link
Owner

What did you do in this PR?

@jfmartinz
Copy link
Owner

Set aside other issue, focus on the issue youre working on, then you can create another one after

@Yashgabani845
Copy link
Contributor Author

@jfmartinz
navbar behaviour was chaning with pages you told me fix the navbar i have fixed in both of the pages about and home ane metioned ss beofore

@jfmartinz
Copy link
Owner

Haha ,sorry. lot of issues reviewed today, most of them are duplciate, just tired maybe hahah

@Yashgabani845
Copy link
Contributor Author

@jfmartinz so what should i consider about this PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐞 [BUG] - Navbar changiing behaviour with pages
2 participants