-
Notifications
You must be signed in to change notification settings - Fork 270
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
website-navbar changing issue solved #766
Conversation
Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊 |
bandicam.2024-06-03.12-41-31-644.mp4@jfmartinz just look at this video this is current situation of white theme |
@jfmartinz condition of dark theme is very good |
Can I see your work? I am trying to enabled the preview in production, so I will see the output easily. Also we're trying to make some unit testing to make sure everything works even after changes of other perople. |
@jfmartinz please checkout the screenshots of both pages as made both identical |
What did you do in this PR? |
Set aside other issue, focus on the issue youre working on, then you can create another one after |
@jfmartinz |
Haha ,sorry. lot of issues reviewed today, most of them are duplciate, just tired maybe hahah |
@jfmartinz so what should i consider about this PR? |
IMPORTANT: When creating your Pull Request, please use the following format for the title:
Category - Resource Name & Section
Closes #672
Description:
i have chnaged mainly css of the about page
and made same as ther home page
Request :
i want to request you about one thing
i saw that css of home page is getting bad after many PRs
someone has remvoed dark mode button and someone has removed toggle button
so please look at the file changes people are chnaging style of other things for their feature
Checklist:
Before submitting your pull request, ensure that you have completed the following tasks: