Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixing navbar for phones #1485

Merged
merged 1 commit into from
Jun 29, 2024

Conversation

kunalmaurya6
Copy link
Contributor

@kunalmaurya6 kunalmaurya6 commented Jun 26, 2024

Pull Request

Description

Please include a summary of the changes and the related issue.
issue no. #1482
i fix navbar bug

Closes #

Type of change

  • Adding a new Resource
  • Adding a new Category
  • Documentation enhancement or fixes
  • Website enhancement or fixes

Checklist:

  • I read carefully CONTRIBUTING.md
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Screenshots (if appropriate):

Please add screenshots to help explain your changes.

Additional

Copy link

Thank you for submitting your pull request! 🙌 We'll review it as soon as possible. In the meantime, please ensure that your changes align with our CONTRIBUTING.md. If there are any specific instructions or feedback regarding your PR, we'll provide them here. Thanks again for your contribution! 😊

@jfmartinz
Copy link
Owner

Can you provide ss or a short mp4 to demonstrate the changes?

@kunalmaurya6
Copy link
Contributor Author

Hi @jfmartinz
Before changes - when we open or refresh page navbar remains opened then we need to manually close.

After changes - when we open or refresh page navbar remains closed.

Can you increase level bcz this is part of js.
Thankyou

VIDEO_0195f493-845a-4056-bbf3-7b6ba9d9bcf7.mp4

@jfmartinz jfmartinz merged commit 26e83f2 into jfmartinz:main Jun 29, 2024
1 of 2 checks passed
@jfmartinz jfmartinz added level2 and removed level1 labels Jun 29, 2024
Copy link

🎉 Your pull request has been successfully merged! 🎉 Thank you for your valuable contribution to our project. Your efforts are greatly appreciated. Feel free to reach out if you have any more contributions or if there's anything else we can assist you with. Keep up the fantastic work! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants