Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option for multiple secrets #10

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

BrutalBirdie
Copy link

@jfederico
Copy link
Owner

Thanks for the PR @BrutalBirdie, it looks good. Just a couple of comments.

1- It is outdated now, if you don't mind and still would like me to merge it, you would have to rebase it. I would have done it but you locked me out to edit your branch.
2- I was also going to add the env variables to the dotenv file. I agree to include them, but the dotenv is kindda the only documentation this script has, so, better to include them in the same way scalelite does.

I can take the code and make the changes myself, but I rather have you credited for the contribution.

Thanks again

@BrutalBirdie
Copy link
Author

Will take a look tomorrow

@jfederico jfederico changed the title Added option for multible secrets Added option for multiple secrets Jun 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants