snap: add snap manifest #3723
snap: add snap manifest #3723
Conversation
|
Hello, I'm extremely interested in this, is there any chance that this can be accepted? I have experience with snaps, and I'm willing to help if needed. |
|
Hello @jesseduffield Very sorry for the delay. Needed to take time off for exams and my laptop needed some service. I have made the changes as you requested. |
snap/snapcraft.yaml
Outdated
| - go | ||
| override-pull: | | ||
| craftctl default | ||
| craftctl set version=$(git describe --tags --abbrev=0 | cut -c 2-) |
There was a problem hiding this comment.
This feels a little broad. Can we ensure it actually has the shape vX.Y
There was a problem hiding this comment.
This will always pull the latest tag. So, you want that if for some reason, you create a tag 45.0 instead of v45.0, the version is still shown as 45.0 right?
There was a problem hiding this comment.
My concern is that sometimes we will push random tags that aren't actually intended to be releases e.g. pre-releases or things I'm personally testing. So we need to get the latest tag with the correct shape (vX.Y)
There was a problem hiding this comment.
Uhh... I get it. The problem is, at least at one place, you'll have to mention the version, it can be in the source where you're pulling it or version of the snap. We can definitely have a cron job to automate it, but when the snap is in the upstream repo, I believe that's the best option.
There was a problem hiding this comment.
That's why I think the current implementation is the best. Where you just update the top-level version for the snap and the rest will be taken care of automatically.
There was a problem hiding this comment.
I'm not following: what's wrong with the override-pull approach that just gets the latest version tag?
This reverts commit 9227b30.
Adds the snap package manifest
go generate ./...)There is a package for lazygit in the snap store, but that's old and seems to be unmaintained. It'd be great if lazygit can be updated and upstreamed. Thanks!