Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STMNIST addition to snntorch #273

Merged
merged 14 commits into from
Mar 8, 2024

Conversation

shatoparbabanerjee
Copy link
Contributor

Training on ST-MNIST with Tonic + snnTorch Tutorial

@jeshraghian
Copy link
Owner

Will check over the ipynb notebook shortly. Could you revert the title of Tutorial 6 back to what it was before?
We don't want to change that.

@jeshraghian
Copy link
Owner

Note: you can just push another commit with the updated changes without making a new pull request. Everything will automatically be updated here.

@shatoparbabanerjee
Copy link
Contributor Author

Note: you can just push another commit with the updated changes without making a new pull request. Everything will automatically be updated here.

Sure I changed Tutorial 6 back, everything should be updated!

@jeshraghian
Copy link
Owner

Structure & results are really solid.
I've just started making some minor changes mainly to make things more succinct.

Could you update the following:

  • A few of the title headers aren't loading properly and need a space between ## and the text.
  • remove the code blocks that are fully commented + unnecessary comments (e.g., s 1.7, and s 3)
  • The test set accuracy plot isn't needed as there are only 3 sample points; I think you should just print the final value

Really cool stuff though; I'll have to share this with the OG authors of the ST-MNIST paper.

@shatoparbabanerjee
Copy link
Contributor Author

Structure & results are really solid. I've just started making some minor changes mainly to make things more succinct.

Could you update the following:

  • A few of the title headers aren't loading properly and need a space between ## and the text.
  • remove the code blocks that are fully commented + unnecessary comments (e.g., s 1.7, and s 3)
  • The test set accuracy plot isn't needed as there are only 3 sample points; I think you should just print the final value

Really cool stuff though; I'll have to share this with the OG authors of the ST-MNIST paper.

Do you want us to delete the code block in 1.5 which has the option to run the full transform vs short transform? Also there is a link in your tutorials where theres a button that says "open in drive" how do we get that GitHub colab link?

@jeshraghian
Copy link
Owner

Do you want us to delete the code block in 1.5 which has the option to run the full transform vs short transform?

Yep just go with one of the two transforms.

Also there is a link in your tutorials where theres a button that says "open in drive" how do we get that GitHub colab link?

We need to merge this first and then the ipynb file will have a solid URL.
In the meantime, just copy paste the URL from another tutorial and change the ipynb file name to this one.

@jeshraghian jeshraghian merged commit 56063fb into jeshraghian:master Mar 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants