Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to Python 3.12 #1327

Merged
merged 4 commits into from
Dec 3, 2023
Merged

upgrade to Python 3.12 #1327

merged 4 commits into from
Dec 3, 2023

Conversation

jertel
Copy link
Owner

@jertel jertel commented Dec 2, 2023

Description

Upgrade to Python 3.12 and correct unit tests that broke.

Checklist

  • I have reviewed the contributing guidelines.
  • I have included unit tests for my changes or additions.
  • I have successfully run make test-docker with my changes.
  • I have manually tested all relevant modes of the change in this PR.
  • I have updated the documentation.
  • I have updated the changelog.

Questions or Comments

@jertel jertel changed the title upgrade to Python 3.12 WIP: upgrade to Python 3.12 Dec 2, 2023
@jertel
Copy link
Owner Author

jertel commented Dec 2, 2023

Still pending: replacement of utcnow(). This isn't critical but would be nice to finish it now versus waiting.

@jertel
Copy link
Owner Author

jertel commented Dec 2, 2023

Update: I've resolved the majority of the deprecation notices. There are still a few remaining:

python_dateutil - this package appears to have been abandoned. There hasn't been an update in years. I've removed some references to it but there are about 4 remaining that will need to be refactored away from dateutil.

botocore - there is an open issue tracking this deprecation: boto/boto3#3889

tencentcloud - I don't see any signs that the team maintaining that project is aware of the deprecation. In fact it looks like they are only certified with Python 3.10. This is the line causing the deprecation: https://github.com/TencentCloud/tencentcloud-sdk-python/blob/4c3ac77e720958029de11d3cd0f55da5fdcbf5b8/tencentcloud/common/abstract_client.py#L209

I think this PR is sufficient for the next release. A separate effort can resume the deprecation resolutions later.

@jertel jertel changed the title WIP: upgrade to Python 3.12 upgrade to Python 3.12 Dec 2, 2023
@nsano-rururu
Copy link
Collaborator

It seems that python-dateutil has been merging merge requests recently, but as you said, there is no sign that a new version will be released.

@nsano-rururu nsano-rururu merged commit a22248a into master Dec 3, 2023
1 check passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 17, 2024
@nsano-rururu
Copy link
Collaborator

@jertel

python_dateutil - this package appears to have been abandoned. There hasn't been an update in years. I've removed some references to it but there are about 4 remaining that will need to be refactored away from dateutil.

It seems that dateutil has been updated. It seems that there was also a response to the deprecation warning of python3.12.

https://github.com/dateutil/dateutil/releases

@jertel
Copy link
Owner Author

jertel commented Mar 3, 2024

Thanks. Updated in #1388.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants